Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AYON: Use SettingsField from ayon server #6173

Merged
merged 4 commits into from Jan 26, 2024

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jan 26, 2024

Changelog Description

This is preparation for new version of pydantic which will require to customize the field class for AYON purposes as raw pydantic Field could not be used.

Testing notes:

  1. Create server packages.
  2. Upload packages to AYON server.
  3. Restart server.
  4. Add the addon versions to a bundle.
  5. Try to open each addon settings (all of them should be visible and working).
  • aftereffects
  • applications
  • blender
  • celaction
  • clockify
  • core
  • deadline
  • fusion
  • hiero
  • houdini
  • max
  • maya
  • nuke
  • photoshop
  • resolve
  • royal render
  • substancepainter
  • timers manager
  • traypublisher
  • tvpaint
  • unreal

This is preparation for new version of pydantic which will require to customize the field for AYON purposes and raw pydantic Field could not be used.
@BigRoy
Copy link
Collaborator

BigRoy commented Jan 26, 2024

Interesting - outside of this PR this could have quite an influence on anyone having customized settings on top of AYON. They would need to align.

Not sure when the pydantic update is 'scheduled' but it would be good to maybe make a clear announcement to devs to make sure to refactor along because say "in a month" or so pydantic will update and using Field will start to fail.

@iLLiCiTiT
Copy link
Member Author

Not sure when the pydantic update is 'scheduled' but it would be good to maybe make a clear announcement to devs to make sure to refactor along because say "in a month" or so pydantic will update and using Field will start to fail.

It is not scheduled at this moment. I think it will happen when all addons will be separated, pre-requirement for separation is to renamed openpype to ayon_core, so they'd have to do more changes than this anyway...

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through all Settings for Ayon Addons and all seems fine and present. With all options available.

I did also compare it side by side to a server before this PR. so should be 100% proven.

Note: I also did those missing in the list like SiteSync and Slack...were working and looking fine too!

@kalisp kalisp assigned iLLiCiTiT and unassigned LiborBatek Jan 26, 2024
@iLLiCiTiT iLLiCiTiT merged commit f3b1570 into develop Jan 26, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/use-settings-field-in-ayon-settings branch January 26, 2024 17:05
@ynbot ynbot added this to the next-patch milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants