-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publisher: Show message with error on action failure #6179
Publisher: Show message with error on action failure #6179
Conversation
Could you share a screen capture of what this looks like? Does the error show in the Report? I'm asking because it has also often come up that there's also NO response whatsoever from a succesful run of an action where the action does produce logs and preferably that output would be visualized. I wonder whether that case could also be solved with code similar to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes make sense, but didn't test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Changelog Description
This PR adds support for the publisher to show error message from running actions.
Errors from actions will otherwise be hidden from user in various console outputs.
Also include card for when action is finished.
Testing notes:
Not sure about a simpler test case, so this where I caught it.
ayon+settings://nuke/create/CreateWriteRender/exposed_knobs
enter an invalid knob name likecreate_directo
.render
in Nuke. Error will appear about missing knob.create_directo
on the created instance node.