Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher: Show message with error on action failure #6179

Merged

Conversation

tokejepsen
Copy link
Member

@tokejepsen tokejepsen commented Jan 29, 2024

Changelog Description

This PR adds support for the publisher to show error message from running actions.

Errors from actions will otherwise be hidden from user in various console outputs.

Also include card for when action is finished.

Testing notes:

Not sure about a simpler test case, so this where I caught it.

  1. Checkout Nuke: Expose write knobs - OP-7592 #6137
  2. Merge this PR into the checked out PR.
  3. In ayon+settings://nuke/create/CreateWriteRender/exposed_knobs enter an invalid knob name like create_directo.
  4. Create render in Nuke. Error will appear about missing knob.
  5. Delete knob create_directo on the created instance node.
  6. Validate and run repair action. Error message should appear.

@ynbot ynbot added type: enhancement Enhancements to existing functionality size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Jan 29, 2024
@BigRoy
Copy link
Collaborator

BigRoy commented Jan 29, 2024

Could you share a screen capture of what this looks like? Does the error show in the Report?

I'm asking because it has also often come up that there's also NO response whatsoever from a succesful run of an action where the action does produce logs and preferably that output would be visualized. I wonder whether that case could also be solved with code similar to this.

@tokejepsen
Copy link
Member Author

Could you share a screen capture of what this looks like? Does the error show in the Report?

Its separate pop-up window, similar to when creation fails.

Capture

I've just snug in code for displaying "Action finished." similar to the "Refreshed" card. Shh....

Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense, but didn't test it.

@iLLiCiTiT iLLiCiTiT changed the title Show message with error on action failure. Publisher: Show message with error on action failure Jan 31, 2024
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jakubjezek001 jakubjezek001 merged commit 9058962 into develop Feb 7, 2024
13 checks passed
@ynbot ynbot added this to the next-patch milestone Feb 7, 2024
@tokejepsen tokejepsen deleted the enhancement/OP-8067_publisher_action_error_raising branch February 20, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR changes 0-99 lines, ignoring general files target: AYON target: OpenPype type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants