Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AYON settings: Use bundle name as variant in dev mode #6187

Merged
merged 1 commit into from Feb 1, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Make sure the bundle name is used in dev mode for settings variant.

Additional info

Bundle name was used as variant only if was assigned to current user which broke most of automations where service users were used.

Testing notes:

  1. Use dev bundle name for automation where service API key is used (e.g. on farm).
  2. It should not crash on settings call where would be variant "dev".

@iLLiCiTiT iLLiCiTiT requested a review from kalisp February 1, 2024 14:46
@ynbot ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Feb 1, 2024
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the issue.

@kalisp kalisp assigned iLLiCiTiT and unassigned kalisp Feb 1, 2024
@iLLiCiTiT iLLiCiTiT merged commit 7b3d54a into develop Feb 1, 2024
14 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/always-use-bundle-name-as-dev-variant branch February 1, 2024 17:34
@ynbot ynbot added this to the next-patch milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR changes 0-99 lines, ignoring general files target: AYON type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants