Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AYON Applications: Remove djvview group from default applications #6188

Merged

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

The djv does not have group defined in models so the values are not used anywhere.

Additional info

Values were probably remainders after movement of the settings from OpenPype. DJV has own addon with own path settings. Version change is not necessary as this change does not affect anything in the addon.

Testing notes:

Validate that any applications addon before this PR did not have djv in UI.

  1. Create packages
  2. Upload applications addon
  3. Validate nothing changed

the djvview does not have model and is unused, probably forgotten
@ynbot ynbot added type: enhancement Enhancements to existing functionality size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Feb 1, 2024
@LiborBatek
Copy link
Member

@iLLiCiTiT could you pls elaborate more on what should the check look like pls? like for what should I check and where before/after. Im not really sure in this case... thx!

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Feb 2, 2024

This change did (should) not change anything. So testing is really that "nothing has changed".

@kalisp kalisp assigned iLLiCiTiT and unassigned LiborBatek Feb 5, 2024
@iLLiCiTiT iLLiCiTiT merged commit c8e7c15 into develop Feb 5, 2024
16 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/remove-djv-from-applications-settings branch February 5, 2024 10:25
@ynbot ynbot added this to the next-patch milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants