Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fusion: fix unwanted change to field name in Settings #6193

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Fusion: fix unwanted change to field name in Settings #6193

merged 1 commit into from
Feb 5, 2024
+6 −4

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Feb 2, 2024

Changelog Description

It should be image_format but in previous refactoring PR it fell back to original output_formats which caused enum not to show up and propagate into plugin.

Additional info

Previously:
uwqmpRpzVR
Now:
chrome_XJzvOBzdXV
In images:
fuscript_xehsgoTsDA

Testing notes:

  1. Update Settings - set output format
  2. create image and render instances in fusion, watch that change in Setting propagated into creators

@kalisp
OP-8104 - fix unwanted change to field name
523df05 
It should be image_format but in previous refactoring PR it fell back to original output_formats
@ynbot ynbot added host: Fusion size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working labels Feb 2, 2024
LiborBatek
LiborBatek approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ayon Settings work fine

image

got correctly propagated and working when Publish

image

@kalisp kalisp merged commit d377b28 into develop Feb 5, 2024
15 checks passed
@kalisp kalisp deleted the bugfix/OP-8104_Fusion-createImageSaver branch February 5, 2024 09:32
@ynbot ynbot added this to the next-patch milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

@LiborBatek LiborBatek LiborBatek approved these changes

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

Assignees

@LiborBatek LiborBatek

Labels
host: Fusion size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working
Projects
PR reviewing
Archived in project
Milestone
3.18.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kalisp @iLLiCiTiT @LiborBatek @ynbot