Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max: Add missing workfile creator #6203

Merged
merged 6 commits into from
Mar 4, 2024

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Feb 7, 2024

Changelog Description

Add the missing workfile creator in 3dsMax.

Additional info

For some reason, get_subset_name function can't set the name with the correct variant, although there is variant.
It is using the old subset name workfileAsset.

Testing notes:

  1. Launch Max via launcher
  2. Load Scene
  3. Open publisher
  4. it should automatically create the workfile instance
  5. you can notice the new container (which is hidden and greyed out) named accordingly
  6. Publish workfile
  7. It should be successfully published.

@moonyuet moonyuet added type: enhancement Enhancements to existing functionality sponsored Client endorsed or requested host: 3dsmax Autodesk 3dsmax target: OpenPype target: AYON labels Feb 7, 2024
@ynbot ynbot added the size/S Denotes a PR changes 100-499 lines, ignoring general files label Feb 7, 2024
@moonyuet moonyuet marked this pull request as draft February 7, 2024 10:41
@moonyuet moonyuet marked this pull request as ready for review February 7, 2024 11:43
@antirotor antirotor assigned antirotor and moonyuet and unassigned antirotor Mar 4, 2024
@antirotor
Copy link
Member

Is it the same code that was merged to ayon-core?

@moonyuet
Copy link
Member Author

moonyuet commented Mar 4, 2024

Is it the same code that was merged to ayon-core?

yes it is. the ayon_core version is already merged.

@moonyuet moonyuet merged commit edfc715 into develop Mar 4, 2024
3 checks passed
@moonyuet moonyuet deleted the enhancement/OP-8111_Publishing-of-Workfiles branch March 4, 2024 15:48
@ynbot ynbot added this to the next-patch milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: 3dsmax Autodesk 3dsmax port to AYON size/S Denotes a PR changes 100-499 lines, ignoring general files sponsored Client endorsed or requested target: AYON target: OpenPype type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants