Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiero: colorspace settings aligned with nuke - AY-978 #6249

Conversation

tokejepsen
Copy link
Member

Changelog Description

In order to share the same colorspaces in the workfile in Hiero and Nuke, we need to bring back the workfile settings for colorspaces in Nuke.

In Hiero we also need code to edit the project settings in memory and apply the colorspaces when launching Hiero so any new project gets the correct colorspaces. Due to Foundry not providing Python API methods for setting the project colorspaces, we need to go through the UI widgets to set them, when dealing with in-memory projects.

Also small bugfix when saving the workfile without any sequences.

Testing notes:

  1. Reset color management settings for Global, Nuke and Hiero.
  2. Enable Global color management; project_settings/global/imageio/activate_global_color_management
  3. Launch Nuke and Hiero.
  4. Verify the colorspaces are setup correctly.

@ynbot ynbot added type: enhancement Enhancements to existing functionality size/S Denotes a PR changes 100-499 lines, ignoring general files host: Hiero host: Nuke labels Mar 25, 2024
@jakubjezek001 jakubjezek001 added the sponsored Client endorsed or requested label Apr 3, 2024
@jakubjezek001
Copy link
Member

@tokejepsen once this is finalized can we create the port into ayon-core please.

Co-authored-by: Jakub Ježek <jakubjezek001@gmail.com>
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets apply suggestions so it is ready for merge

@jakubjezek001
Copy link
Member

This should also have ayon-core port please.

@jakubjezek001 jakubjezek001 merged commit 7596ece into develop Apr 9, 2024
3 checks passed
@ynbot ynbot added this to the next-patch milestone Apr 9, 2024
@tokejepsen tokejepsen deleted the enhancement/AY-978_hiero-colorspace-settings-aligned-with-nuke branch April 10, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Hiero host: Nuke port to AYON size/S Denotes a PR changes 100-499 lines, ignoring general files sponsored Client endorsed or requested type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants