Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Removed double conversion of limit_groups #6265

Merged

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented May 2, 2024

Changelog Description

limit_groups settings got transformed twice. Kept nicer looking conversion.

Testing notes:

  1. Set something to ayon+settings://deadline/publish/NukeSubmitDeadline/limit_groups (Limit Groups)
    image

  2. try to open Launcher on some project

  3. it shouldn't throw

    item["name"]: item["value"] for item in nuke_submit.pop("limit_groups")
TypeError: string indices must be integers

and show DCCs

`limit_groups` got tranformed twice. Kept nicer looking conversion.
@kalisp kalisp added type: bug Something isn't working sponsored Client endorsed or requested labels May 2, 2024
@kalisp kalisp requested review from 64qam and iLLiCiTiT May 2, 2024 12:41
@ynbot ynbot added the size/XS Denotes a PR changes 0-99 lines, ignoring general files label May 2, 2024
@kalisp kalisp merged commit c78d24e into develop May 2, 2024
15 checks passed
@kalisp kalisp deleted the bugfix/AY-5218_Ayon-launcher-doesnt-show-applications branch May 2, 2024 13:00
@ynbot ynbot added this to the next-patch milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR changes 0-99 lines, ignoring general files sponsored Client endorsed or requested type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants