-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.13.7 #730
Version 2.13.7 #730
Conversation
Fixed saving namespace into Headline Fixed switch asset and update version Added delete layer by id
…opagating-to-metadata-in-photoshop Photoshop: Fix Layer name was not propagating correctly
…identifier Launcher has unified group identifier
TVPaint integration
…rides Maya: disable legacy override check for cameras
…on' into feature/698-after-effects-publish-to-deadline
…ish_gui Removed artist view from pyblish gui
…ll_same_name_attributes Synchronize ftrack hierarchical and shot attributes
TV Paint: initial implementation with loaders, creators and local rendering
…-instances-by-name Sort instances by label in pyblish gui
Added plugin for incrementing of workfile
Added saving deadline response to instance
…ter-effects-publish-to-deadline
Changed 'render' family in Creator to 'render.farm'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 11, in sys.exit(main()) File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/cli.py", line 18, in main app.run(argv) File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 393, in run self._run(argv) File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 381, in _run self.run_checks() File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 300, in run_checks self.file_checker_manager.run() File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 331, in run self.run_serial() File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 315, in run_serial checker.run_checks() File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 598, in run_checks self.run_ast_checks() File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 502, in run_ast_checks for (line_number, offset, text, check) in runner: File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 56, in run parser.visit(self.tree) File "/usr/lib/python3.6/ast.py", line 253, in visit return visitor(node) File "/usr/lib/python3.6/ast.py", line 261, in generic_visit self.visit(item) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 39, in visit_ClassDef self.capture_issues_visitor('ClassDef', node) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 33, in capture_issues_visitor self.generic_visit(node) File "/usr/lib/python3.6/ast.py", line 263, in generic_visit self.visit(value) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 36, in visit_Call self.capture_issues_visitor('Call', node) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 30, in capture_issues_visitor issues = checker.run(node) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checkers/render.py", line 22, in run if isinstance(arg, ast.Call) and arg.func.id == 'locals': AttributeError: 'Attribute' object has no attribute 'id'
*/ | ||
$.oTool.prototype.activate = function(){ | ||
Tools.setToolSettings({currentTool:{id:this.id}}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
|
||
return stencilsList; | ||
} | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
if (_stencilTypes[i].indexOf(this.name) != -1) stencilsTypeList.push(i); | ||
} | ||
|
||
for (var i in _stencils){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'i' is already defined.
texture:["Brush"], | ||
bitmapbrush:["Brush"], | ||
bitmaperaser:["Eraser"] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
$.oTool = function(id, name){ | ||
this.id = id; | ||
this.name = name; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
*/ | ||
$.oTimeline = function( display){ | ||
this.display = display | ||
this.composition = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
* @property {oScene} scene The scene object of the DOM. | ||
*/ | ||
$.oTimeline = function( display){ | ||
this.display = display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
} | ||
} | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
*/ | ||
$.oProcess.prototype.launchAndDetach = function(){ | ||
QProcess.startDetached(this.bin, this.queryArgs); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
p.waitForFinished(-1); | ||
var result = this.read(); | ||
return result; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 11, in sys.exit(main()) File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/cli.py", line 18, in main app.run(argv) File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 393, in run self._run(argv) File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 381, in _run self.run_checks() File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 300, in run_checks self.file_checker_manager.run() File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 331, in run self.run_serial() File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 315, in run_serial checker.run_checks() File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 598, in run_checks self.run_ast_checks() File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 502, in run_ast_checks for (line_number, offset, text, check) in runner: File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 56, in run parser.visit(self.tree) File "/usr/lib/python3.6/ast.py", line 253, in visit return visitor(node) File "/usr/lib/python3.6/ast.py", line 261, in generic_visit self.visit(item) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 39, in visit_ClassDef self.capture_issues_visitor('ClassDef', node) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 33, in capture_issues_visitor self.generic_visit(node) File "/usr/lib/python3.6/ast.py", line 263, in generic_visit self.visit(value) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 36, in visit_Call self.capture_issues_visitor('Call', node) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 30, in capture_issues_visitor issues = checker.run(node) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checkers/render.py", line 22, in run if isinstance(arg, ast.Call) and arg.func.id == 'locals': AttributeError: 'Attribute' object has no attribute 'id'
} | ||
Action.perform( "onActionChooseSpTransformTool()" ); | ||
$.endUndo(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
//Find the highest voted LCS. | ||
var highest = 0; | ||
var common_name = 'Backdrop'; | ||
for( var n in common_substrings ){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'n' is already defined.
for( var x=n+1;x<names.length;x++ ){ | ||
var lcs = $.utils.longestCommonSubstring(names[n], names[x]); | ||
if( lcs.length>2 ){ | ||
var clean_lcs = lcs.sequence; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'clean_lcs' is already defined.
//Now compare cleaned LCS and accumulate them as votes as well. | ||
for( var n=0;n<names.length;n++ ){ | ||
for( var x=n+1;x<names.length;x++ ){ | ||
var lcs = $.utils.longestCommonSubstring(names[n], names[x]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'lcs' is already defined.
} | ||
|
||
//Now compare cleaned LCS and accumulate them as votes as well. | ||
for( var n=0;n<names.length;n++ ){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'n' is already defined.
"color" : this.color | ||
}; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
"text" : this.gui_text.plainText, | ||
"color" : this.color | ||
}; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
//QTimer::singleShot(0, line, SLOT(setFocus())); | ||
var focusTimer = new QTimer(); | ||
focusTimer.singleShot = true; | ||
focusTimer["timeout"].connect( this, this.focusInput ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
['timeout'] is better written in dot notation.
}catch( err ){ | ||
System.println( err ); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
} | ||
} | ||
|
||
this.gui_buttonColor["clicked"].connect( this, this.changeColor ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
['clicked'] is better written in dot notation.
Other Changes