Copy non-python launch script in each integration #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigRoy
reviewed
Mar 25, 2024
client/ayon_core/lib/ayon_info.py
Outdated
| executable_path = os.environ["AYON_EXECUTABLE"] | ||
| executable_filename = os.path.basename(executable_path) | ||
| if "python" in executable_filename.lower(): | ||
| return False | ||
| return True | ||
|
|
||
|
|
||
| def is_using_ui_executable(): |
There was a problem hiding this comment.
Suggested change
| def is_using_ui_executable(): | |
| def is_using_windows_ui_executable(): |
Should we make it clear that this is windows-specific from the function name as well?
There was a problem hiding this comment.
You're mind reader. We were just discussing it, and came to conclusion that is_using_ayon_console might be the best.
There was a problem hiding this comment.
Now I realized I also have to switch the logic...
kalisp
approved these changes
Mar 26, 2024
|
And actually this https://community.ynput.io/t/dcc-communication-over-websocket-code-duplication/1328 is somehow connected to this PR. Could you please comment here (or there) reasoning/future plans? |
# Conflicts: # client/ayon_core/lib/applications.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Preparation for split of Photoshop, AfterEffects and Harmony integrations into their addon repositories which requires to not use global script and prelaunch hook.
Additional info
Each integration has own launch script and prelaunch hook which cares about the same logic, and removed the global script and prelaunch hook. Removed
get_non_python_host_kwargsfunction from applications logic. Implemented new helper functionis_using_ui_executableto determine if UI executable is used on windows.Renamed constants in each of the host to have
_ADDON_ROOTsuffix instead of_HOST_DIRto match where they point (will point).Testing notes:
ayon_console.exeorayon.exe.ayon_console.exeorayon.exe.ayon_console.exeorayon.exe. (if we have a way how to test?)