Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Houdini: Fix Validate Workfile Paths failing on parms with expressions or keyframes #524

Merged
merged 9 commits into from
Jun 18, 2024
Merged

Houdini: Fix Validate Workfile Paths failing on parms with expressions or keyframes #524

merged 9 commits into from
Jun 18, 2024

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented May 17, 2024

Changelog Description

Validate workfile paths skip parms with keyframes

Additional info

Fix #522

Testing notes:

  1. Load something as Alembic Archive into Houdini
  2. Publish something with workfile instance enabled and validate file paths on

@BigRoy BigRoy requested a review from antirotor May 17, 2024 21:25
MustafaJafar
MustafaJafar approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on my side.
But, I wonder what if some user used expressions as well as the prohibited_vars.
I was going to suggest using rawValue() instead but I found out it doesn't work.

@antirotor
Copy link
Member

we should probably refactor and merge it right after #516 which should be now review priority.

@antirotor antirotor closed this May 27, 2024
@antirotor antirotor reopened this May 27, 2024
@BigRoy
Copy link
Collaborator Author

BigRoy commented Jun 3, 2024

Thanks - I'll work on these once #516 is merged.

@BigRoy BigRoy assigned MustafaJafar and unassigned BigRoy Jun 3, 2024
MustafaJafar
MustafaJafar approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works.

question @iLLiCiTiT:
should we now bump the addon version if we made changes in client code ?

@iLLiCiTiT
Merge branch 'develop' into bugfix/houdini_validate_workfile_paths_ke…
95a76c8 
…yframes

# Conflicts:
#	server_addon/houdini/client/ayon_houdini/version.py
@iLLiCiTiT
bump version to 0.3.2
3ee74b9
@iLLiCiTiT iLLiCiTiT merged commit c3ccae7 into ynput:develop Jun 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MustafaJafar MustafaJafar MustafaJafar approved these changes

@antirotor antirotor Awaiting requested review from antirotor

Assignees

@MustafaJafar MustafaJafar

Labels
host: Houdini size/XS type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Houdini: Workfile path validator crashes when alembic is loaded as Alembic Archive
5 participants
@BigRoy @antirotor @MustafaJafar @iLLiCiTiT @ynbot