Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Houdini: move houdini client code - Add Settings Category #536

Conversation

MustafaJafar
Copy link
Contributor

Changelog Description

Add settings category by implementing a base class.

Additional info

I made a separate PR because I'm not sure if this solution is favored.

Testing notes:

  1. Launch Houdini
  2. Settings should be applied to their corresponding plugins correctly.
  • ayon+settings://houdini/create
  • ayon+settings://houdini/publish

@ynbot
Copy link
Contributor

ynbot commented May 21, 2024

Task linked: AY-4916 Move Houdini client code

@MustafaJafar
Copy link
Contributor Author

MustafaJafar commented May 21, 2024

Note

I thought about implementing this PR because it's so tedious to add settings_category = "houdini" to all publish plugins.

And, it works perfectly with creator plugins because I ALREADY have settings for each single creator plugin.

Unlike with publish plugins. I faced a lot of warnings because many plugins don't have corresponding settings.
I didn't know that filter_pyblish_plugins make warning if plugins don't have settings. I thought these plugins will be just ignored.

*** WRN: >>> { filter_pyblish_plugins }: [  Couldn't find plugin 'ValidatePrimitiveHierarchyPaths' settings under settings category 'houdini'  ] 
*** WRN: >>> { filter_pyblish_plugins }: [  Couldn't find plugin 'SaveCurrentScene' settings under settings category 'houdini'  ] 
*** WRN: >>> { filter_pyblish_plugins }: [  Couldn't find plugin 'ExtractOpenGL' settings under settings category 'houdini'  ] 
*** WRN: >>> { filter_pyblish_plugins }: [  Couldn't find plugin 'ExtractAlembic' settings under settings category 'houdini'  ] 
*** WRN: >>> { filter_pyblish_plugins }: [  Couldn't find plugin 'ExtractBGEO' settings under settings category 'houdini'  ] 
*** WRN: >>> { filter_pyblish_plugins }: [  Couldn't find plugin 'ExtractComposite' settings under settings category 'houdini'  ] 
*** WRN: >>> { filter_pyblish_plugins }: [  Couldn't find plugin 'ExtractHDA' settings under settings category 'houdini'  ] 
*** WRN: >>> { filter_pyblish_plugins }: [  Couldn't find plugin 'ExtractMantraIFD' settings under settings category 'houdini'  ] 
*** WRN: >>> { filter_pyblish_plugins }: [  Couldn't find plugin 'ExtractRender' settings under settings category 'houdini'  ] 
*** WRN: >>> { filter_pyblish_plugins }: [  Couldn't find plugin 'ExtractUSD' settings under settings category 'houdini'  ] 
*** WRN: >>> { filter_pyblish_plugins }: [  Couldn't find plugin 'ExtractUSDLayered' settings under settings category 'houdini'  ] 
*** WRN: >>> { filter_pyblish_plugins }: [  Couldn't find plugin 'ExtractAss' settings under settings category 'houdini'  ] 
*** WRN: >>> { filter_pyblish_plugins }: [  Couldn't find plugin 'ExtractFBX' settings under settings category 'houdini'  ] 
*** WRN: >>> { filter_pyblish_plugins }: [  Couldn't find plugin 'ExtractRedshiftProxy' settings under settings category 'houdini'  ] 
*** WRN: >>> { filter_pyblish_plugins }: [  Couldn't find plugin 'ExtractVDBCache' settings under settings category 'houdini'  ] 
*** WRN: >>> { filter_pyblish_plugins }: [  Couldn't find plugin 'ExtractActiveViewThumbnail' settings under settings category 'houdini'  ] 
*** WRN: >>> { filter_pyblish_plugins }: [  Couldn't find plugin 'IncrementCurrentFile' settings under settings category 'houdini'  ] 

@MustafaJafar MustafaJafar marked this pull request as draft May 21, 2024 20:30
…916_Move-Houdini-client-code-settings-category
@MustafaJafar MustafaJafar marked this pull request as ready for review May 23, 2024 09:42
…916_Move-Houdini-client-code-settings-category
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did simple test in my side. Looks good.
image

@MustafaJafar MustafaJafar requested a review from BigRoy May 24, 2024 13:36
@MustafaJafar MustafaJafar merged commit 3658eca into chore/AY-4916_Move-Houdini-client-code May 31, 2024
@MustafaJafar MustafaJafar deleted the chore/AY-4916_Move-Houdini-client-code-settings-category branch May 31, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants