Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Move Maya addon code #546

Merged
merged 6 commits into from
May 30, 2024
Merged

Conversation

antirotor
Copy link
Member

Changelog Description

Move client Maya addon code from AYON core to the folder along the server part. Refactoring imports to accommodate this move.

Additional info

This is also adding rather hacked support of inline codespell ignores to ease development. You can now use syntax:

foo = "some intentional tipo"  # codespell:ignore tipo

In next release of codespell (>2.2.6) it should be natively supported.

Testing notes:

Build and install the addon
Test the integration

@antirotor antirotor self-assigned this May 23, 2024
@antirotor antirotor added enhancement New feature or request host: Maya labels May 23, 2024
@ynbot
Copy link
Contributor

ynbot commented May 23, 2024

Task linked: AY-4908 Move Maya client code

@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented May 27, 2024

It is also required to define settings_category = "maya" in the plugins so settings can be applied automatically.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems normal and working ok.

Did bunch of tests for publishing etc. All good.

@antirotor
Copy link
Member Author

With the settings category, we need to retest loading and publishing. Should work as before.

All plugins have their own Maya specific base class defining settings category and host now.

@iLLiCiTiT iLLiCiTiT merged commit 6eaf81f into develop May 30, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the chore/AY-4908_move-maya-code branch May 30, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants