Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip freeze fix 2 #105

Merged
merged 2 commits into from Mar 6, 2024
Merged

Pip freeze fix 2 #105

merged 2 commits into from Mar 6, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Following PR to #104 . This should really fix issue with invalid data in requirements.txt .

Additional info

Instead of storing requirements txt which contains dynamic reference like HEAD or master we're storing a json which is just converted lock file which contains resolved reference (git commit hash).

Testing notes:

  1. Run build and make installer.
  2. The git packages (acre and appdirs) should have git url with commit hash at the end.

@BigRoy
Copy link
Contributor

BigRoy commented Mar 6, 2024

This PR fixes the remaining issues I faced described here.

With Launcher rebuild and a new installer created I was able to use this to actually build a dependency package with the Ayon Dependencies Tool.

Thanks!

@iLLiCiTiT iLLiCiTiT merged commit 5126cd3 into develop Mar 6, 2024
@iLLiCiTiT iLLiCiTiT deleted the bugfix/pip-fix-attempt-2 branch March 6, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants