Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create_package.py #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MustafaJafar
Copy link
Contributor

Changelog Description

Skip few paths if they don't exist.

Additional info

This PR is not necessary for this example addon as pyproject.toml and frontend always exist.
But, this PR becomes handy when someone is using this addon as template where they may don't need pyproject.toml and frontend.

Note

Please feel free to suggest closing this PR if you think it doesn't add a value.

@iLLiCiTiT
Copy link
Member

This PR is not necessary for this example addon as pyproject.toml and frontend always exist.
But, this PR becomes handy when someone is using this addon as template where they may don't need pyproject.toml and frontend.

Shouldn't they modify the script in that case?

@MustafaJafar
Copy link
Contributor Author

Shouldn't they modify the script in that case?

Yes, I just wanted to simplify it for newcomers.

@iLLiCiTiT
Copy link
Member

Then I would add some explanation comments. Now newcommers would have to read the code to understand...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants