Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Always fail on risky whatever the error #20

Merged
merged 13 commits into from Apr 2, 2023
Merged

Conversation

yoanm
Copy link
Owner

@yoanm yoanm commented Apr 2, 2023

No description provided.

@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Merging #20 (03310e7) into master (44c506b) will increase coverage by 2.72%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master       #20      +/-   ##
=============================================
+ Coverage     97.27%   100.00%   +2.72%     
- Complexity       47        49       +2     
=============================================
  Files             4         4              
  Lines           110       110              
=============================================
+ Hits            107       110       +3     
+ Misses            3         0       -3     
Flag Coverage Δ
functional-tests 100.00% <100.00%> (+2.72%) ⬆️
php-8.2 100.00% <100.00%> (+2.72%) ⬆️
sf-9.0 100.00% <100.00%> (+2.72%) ⬆️
unit-tests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Listener/DelegatingListener.php 100.00% <100.00%> (ø)
src/Listener/RiskyToFailedListener.php 100.00% <100.00%> (+4.76%) ⬆️
src/Listener/StrictCoverageListener.php 100.00% <100.00%> (+5.26%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yoanm yoanm marked this pull request as ready for review April 2, 2023 17:49
@yoanm yoanm merged commit c5ebdfd into master Apr 2, 2023
11 of 13 checks passed
@yoanm yoanm deleted the fix/always-fail-on-risky branch April 2, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant