Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow url without .git suffix #17

Closed
mborejdo opened this issue Aug 30, 2020 · 2 comments
Closed

Allow url without .git suffix #17

mborejdo opened this issue Aug 30, 2020 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@mborejdo
Copy link

Is your feature request related to a problem? Please describe.
using gitweb on a repo which has not been checked out with the .git-suffix results in a panic.

thread` 'main' panicked at 'called `Option::unwrap()` on a `None` value'

Describe the solution you'd like
The regex should allow all valid git urls.

@yoannfleurydev
Copy link
Owner

Hi, thanks a lot for opening this issue, that is a nice catch.

@yoannfleurydev yoannfleurydev added this to the v1.0.0 milestone Aug 30, 2020
@yoannfleurydev yoannfleurydev added the bug Something isn't working label Aug 30, 2020
yoannfleurydev added a commit that referenced this issue Oct 5, 2020
yoannfleurydev added a commit that referenced this issue Oct 5, 2020
@yoannfleurydev
Copy link
Owner

Hi.

So I did a complete rewrite of the code as it was poorly written the first time as I did code this CLI to learn Rust. This issue is fixed in the new 0.2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants