Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the "pretty" function to be locale-dependent #199

Closed
yoavnir opened this issue Dec 13, 2022 · 1 comment
Closed

Change the "pretty" function to be locale-dependent #199

yoavnir opened this issue Dec 13, 2022 · 1 comment
Labels
enhancement New feature or request Future Enhancement of fix for a future version good first issue Good for newcomers usability
Milestone
Version 0.9.5

Comments

@yoavnir
Copy link
Owner

yoavnir commented Dec 13, 2022

So in Germany it might use periods for thousands separators and commas for decimal.
@yoavnir yoavnir added enhancement New feature or request good first issue Good for newcomers Future Enhancement of fix for a future version usability labels Dec 13, 2022
@yoavnir yoavnir added this to the Version 0.9.5 milestone May 14, 2024
@yoavnir
Copy link
Owner Author

yoavnir commented Jul 6, 2024

So in Germany it might use periods for thousands separators and commas for decimal.

Turns out that the de_DE locale does not use a thousands separator...

yoavnir added a commit that referenced this issue Jul 6, 2024
@yoavnir
Issue #199 - Add locale support to the pretty function
acf727a
yoavnir added a commit that referenced this issue Jul 6, 2024
@yoavnir
Issue #199 - Add locale support to the pretty function
ca6c7a4
yoavnir added a commit that referenced this issue Jul 6, 2024
@yoavnir
Merge pull request #244 from yoavnir/dev-0.9.5-issue-199
1cffe28 
Issue #199 - Add locale support to the pretty function
@yoavnir yoavnir closed this as completed Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Future Enhancement of fix for a future version good first issue Good for newcomers usability
Projects
None yet
Milestone
Version 0.9.5
Development

No branches or pull requests
1 participant
@yoavnir