Does not rerender when values changes

[Herdismaria]

Tried using the new version but it's still not working.
GetDerivedStateFromProps returns null even though values object changes.
I think the we need to store forceStatic in the state.

when we store forcesStatic in the state it triggers a rerender if we omit it after first render on the client.

The same but without storing forceStatic in the state

[Herdismaria]

We are not using the values object to construct the query so even thought it changes the query does not change so getDerivedStateFromProps returns null?

[yocontra]

@Herdismaria I just made a branch called static-fix, can you try that and see if it works for you?

[Herdismaria]

const getValues = ({ values }) => {
  if (!values) return null
  const keys = Object.keys(values)
  if (keys.length === 0) return null
  return keys.reduce((result, key) => {
    result[hyphenate(key)] = values[key]
    return result
  }, {})
}

if this returns null, we'll get an error when doing Object.keys(null) in getDerivedStateFromProps

static getDerivedStateFromProps(props, state) {
    const query = getQuery(props)
    if (!query) throw new Error('Invalid or missing MediaQuery!')
    const values = getValues(props)
    if (query === state.query && values === state.values) return null // nothing changed
    const forceStatic = Object.keys(values).length !== 0
    const mq = matchMedia(props, query, forceStatic)
    return {
      matches: mq.matches,
      mq,
      query,
      values
    }
  }

[yocontra]

@Herdismaria Pushed a fix.

[s-diez]

I had the same problem as @Herdismaria and tried the suggested branch. I does contain one error but seems to work otherwise.

The error:

https://github.com/contra/react-responsive/compare/static-fix#diff-1fdf421c05c1140f6d71444ea2b27638R48

matchMedia() has to be called with matchMedia(query, props, !!values) instead of matchMedia(props, query, !!values).

[yocontra]

@s-diez Pushed

There is a test failure on this branch though, would need to be fixed before merging

[molcik]

Any progress on this?

[yocontra]

@molcik Just waiting on somebody to test the static-fix branch and confirm it is fixed

[yocontra]

@molcik If you're having the same issue, can you test the branch?

[yocontra]

Published a fix as 6.1.2 - please test and let me know if it is still an issue and I can reopen.