Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react@0.14.0 #80

Closed
BarryThePenguin opened this issue Jan 31, 2017 · 2 comments
Closed

react@0.14.0 #80

BarryThePenguin opened this issue Jan 31, 2017 · 2 comments

Comments

@BarryThePenguin
Copy link

BarryThePenguin commented Jan 31, 2017 •
edited
Loading

Is there a reason react@0.14.0 isn't listed as a peerDependency? I saw #66 had problems with server side rendering, but like you mentioned it was an upstream issue. Apologies if this is opening old wounds 馃槼

Edit: should mention that this causes npm shrinkwrap to fail..
@yocontra
Copy link
Owner

Can't remember why but for some reason this didn't work with 0.14, if you think it works fine and can't find any issues that say otherwise feel free to send a PR that adds it back in and I'll publish a release

@jesstelford
Copy link
Contributor

We haven't had any issues with v0.14.x, used across 10's of different modules. I'll open a PR.

@jesstelford jesstelford mentioned this issue Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yocontra @jesstelford @BarryThePenguin