Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling setState on componentWillMount broke iso rendering with react@^0.14 #66

Closed
ascariandrea opened this issue Nov 7, 2016 · 7 comments

Comments

@ascariandrea
Copy link

Hi,
I'm facing an issue related to the usage of setState in the componentWillMount in component inside the React.renderToString function, react#6423.

Are you aware of this?
I could try to resolve this if you're intended to support it.
Thanks

@yocontra
Copy link
Owner

Still happening on v15?

@ascariandrea
Copy link
Author

Nope, they fixed it.

@ascariandrea
Copy link
Author

Are you ignoring the issue?

@yocontra
Copy link
Owner

yocontra commented Nov 25, 2016

They fixed it upstream and it isn't a problem anymore, so I'm closing it. There's nothing to fix. Please don't tell people how to use their issue trackers.

@ascariandrea
Copy link
Author

Yep, they fixed it upstream, but the peerDependencies in the package.json says the package is compatible with react^0.14.0, so it's still a problem.

yocontra pushed a commit that referenced this issue Nov 25, 2016
@yocontra
Copy link
Owner

yocontra commented Nov 25, 2016

If I run npm update or npm install react react-responsive and the problem doesn't persist then the issue is fixed and there's nothing to do about it.

I removed 0.14 from the package if that's what you're looking for - peerDependency ranges aren't enforced, so it won't really do anything though.

@ascariandrea
Copy link
Author

I didn't want the peerDependencies to be modified and I even didn't want a fight on this.
I use your package (as a lot of people do) and I had an issue, I reported it and tried to help with a PR that you closed without a real discussion. As being said, thank you for your time, I won't bother you again. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants