Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable trace/httpsession tests #266

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Conversation

yorkie
Copy link
Member

@yorkie yorkie commented Jan 11, 2019

The above module tests failed on current CI, let's just skip it for now.

The above module tests failed on current CI, let's just skip it
for now.
@rokidbot
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Contributor

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #266 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   64.17%   64.17%           
=======================================
  Files          50       50           
  Lines        3249     3249           
=======================================
  Hits         2085     2085           
  Misses       1164     1164

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6fd5e8...3337024. Read the comment docs.

@yorkie yorkie merged commit e368fc4 into master Jan 11, 2019
@yorkie yorkie deleted the disable/some-invalid-test branch January 11, 2019 09:42
yorkie added a commit that referenced this pull request Jan 16, 2019
The above module tests failed on current CI, let's just skip it
for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants