Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

volume-app: deref context on url of context manager #655

Merged
merged 1 commit into from
Apr 22, 2019
Merged

volume-app: deref context on url of context manager #655

merged 1 commit into from
Apr 22, 2019

Conversation

legendecas
Copy link
Contributor

Checklist
  • npm test passes

@legendecas legendecas added the app label Apr 22, 2019
@legendecas legendecas requested a review from a team as a code owner April 22, 2019 06:51
@rokidbot
Copy link
Contributor

Can one of the admins verify this patch?

@yorkie yorkie merged commit 635fde9 into master Apr 22, 2019
@yorkie yorkie deleted the fix/volume branch April 22, 2019 08:38
legendecas added a commit that referenced this pull request Apr 28, 2019
@legendecas
volume-app: deref context on url of context manager (#655)
f5a81a2
@legendecas legendecas mentioned this pull request Apr 28, 2019
Closed
legendecas added a commit that referenced this pull request Apr 28, 2019
@legendecas
volume-app: deref context on url of context manager (#655)
2cb21e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorkie yorkie yorkie approved these changes

Assignees
No one assigned
Labels
app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legendecas @rokidbot @yorkie