Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-scheduler: generate coredump on ANR #875

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

legendecas
Copy link
Contributor

Generate coredump on application not responding for convenient debugging.

Checklist
  • npm test passes
  • tests and/or benchmarks are included

@legendecas legendecas requested a review from a team as a code owner September 18, 2019 07:30
@ghost ghost requested review from FeelyChau and yorkie September 18, 2019 07:30
@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #875 into master will decrease coverage by 0.19%.
The diff coverage is 47.82%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #875     +/-   ##
=========================================
- Coverage   71.96%   71.76%   -0.2%     
=========================================
  Files          60       60             
  Lines        2418     2430     +12     
=========================================
+ Hits         1740     1744      +4     
- Misses        678      686      +8
Impacted Files Coverage Δ
runtime/app/executable-launcher.js 21.62% <0%> (-2.63%) ⬇️
runtime/app/default-launcher.js 18.91% <0%> (-2.3%) ⬇️
runtime/app/app-bridge.js 77.92% <100%> (+0.29%) ⬆️
runtime/component/app-scheduler.js 84.97% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f6827...b4ec612. Read the comment docs.

Copy link
Member

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@legendecas legendecas merged commit 9bb8db3 into yodaos-project:master Sep 18, 2019
@legendecas legendecas deleted the core-dump-on-anr branch September 18, 2019 12:28
@yorkie yorkie mentioned this pull request Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants