Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label is not available in plugin options (but placeholder is) #10

Closed
Tofandel opened this issue Jul 2, 2020 · 5 comments
Closed

Label is not available in plugin options (but placeholder is) #10

Tofandel opened this issue Jul 2, 2020 · 5 comments
Labels

Comments

@Tofandel
Copy link
Contributor

Tofandel commented Jul 2, 2020

The label prop is not taken from the plugin options, this is inconsistent behavior and it should be configurable like placeholder is

Vue.use(VueTelInputVuetify, {
  vuetify,
  placeholder: '',
  label: 'Phone'
});
github-actions bot pushed a commit that referenced this issue Jul 12, 2020
## [1.2.3](v1.2.2...v1.2.3) (2020-07-12)

### Bug Fixes

* **core:** add label in plugin options ([7cfa111](7cfa111)), closes [#10](#10)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@yogakurniawan
Copy link
Owner

@Tofandel i have fixed this issue. can you check if this issue solved ?

@Tofandel
Copy link
Contributor Author

Tofandel commented Jul 13, 2020

@yogakurniawan

Nope it's still missing in the props of the component

    label: {
      type: String,
      default: 'Enter a Phone Number',
    },
    placeholder: {
      type: String,
      default: () => getDefault('placeholder'),
    },

Should be

    label: {
      type: String,
      default: () => getDefault('label'),
    },
    placeholder: {
      type: String,
      default: () => getDefault('placeholder'),
    },

@yogakurniawan yogakurniawan reopened this Jul 13, 2020
@yogakurniawan
Copy link
Owner

okay it's fixed now in version 1.2.6

yogakurniawan referenced this issue Jul 13, 2020
fix default label
@yogakurniawan
Copy link
Owner

closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants