Switching countries changes phone numbers incorrectly #22
Labels
Comments
|
I've the same issue! |
github-actions bot
pushed a commit
that referenced
this issue
Jul 28, 2020
## [1.2.12](v1.2.11...v1.2.12) (2020-07-28) ### Bug Fixes * **component:** fix issue switching countries ([bf6e26e](bf6e26e)), closes [#22](#22)
|
🎉 This issue has been resolved in version 1.2.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@jsshapiro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current behavior
When switching countries, at vue-tel-input-vuetify.vue#571, the code incorrectly uses the .national version of the phone number rather than the .significant version. There is no sensible scenario, when switching countries, where we would want to preserve the local-dialing prefix that is included in the
.nationalversion of the phone number. This bug is inherited from upstream, and I have filed a bug there as well.Repeat by:
What has happened is that the leading zero added for local dialing in Algeria has been added to the number because
.nationalwas used rather than.significant.Expected behavior
Expected behavior is that the leading zero that is only significant for in-nation dialing within Algeria does not contaminate the phone number after switching countries.
The use-case is that the user has started keying a phone number, realizes that they have the wrong country selected, and changes the country drop-down to select the intended country. This should not alter the numbers they have typed.
Versions
Problem observed in v1.2.11, but since this looks to be inherited from up-stream, I suspect it's a long-term issue.
Environment:
Problem is environment-independent.
Recommended Fix
The recommended fix is to change the code to use
.significantrather than.national. Note that in all cases where.nationalhas been set,.significanthas also been set.The text was updated successfully, but these errors were encountered: