Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some typos / mistakes in README #1132

Merged
merged 4 commits into from
Dec 19, 2023
Merged

fix some typos / mistakes in README #1132

merged 4 commits into from
Dec 19, 2023

Conversation

jxdv
Copy link
Contributor

@jxdv jxdv commented Dec 12, 2023

^title

AnonymousWP
AnonymousWP requested changes Dec 13, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@jxdv @AnonymousWP
add parenthesis
bf2cde6 
Co-authored-by: Anonymoussaurus <50231698+AnonymousWP@users.noreply.github.com>
AnonymousWP
AnonymousWP approved these changes Dec 16, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
AnonymousWP
AnonymousWP requested changes Dec 16, 2023
View reviewed changes
Copy link
Collaborator

@AnonymousWP AnonymousWP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I meant to request, not approve.

@jxdv @AnonymousWP
Update README.md
a56a9c1 
Co-authored-by: Anonymoussaurus <50231698+AnonymousWP@users.noreply.github.com>
@AnonymousWP AnonymousWP requested review from psyray and yogeshojha and removed request for psyray December 16, 2023 19:36
@yogeshojha yogeshojha added this to the release 2.1.0 milestone Dec 18, 2023
@yogeshojha yogeshojha changed the base branch from master to release/2.1.0 December 18, 2023 01:37
@yogeshojha
Copy link
Owner

@jxdv please fix merge conflict.

@jxdv
Copy link
Contributor Author

jxdv commented Dec 18, 2023

@jxdv please fix merge conflict.

Done.

@AnonymousWP AnonymousWP merged commit 667f5b8 into yogeshojha:release/2.1.0 Dec 19, 2023
1 check passed
@jxdv jxdv deleted the update-readme branch December 19, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psyray psyray psyray approved these changes

@AnonymousWP AnonymousWP AnonymousWP approved these changes

@yogeshojha yogeshojha Awaiting requested review from yogeshojha

Assignees
No one assigned
Labels
release/2.1.0
Projects
None yet
Milestone
release 2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jxdv @yogeshojha @psyray @AnonymousWP