Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation: Check docker running status before installing reNgine. #468

Merged
merged 3 commits into from Aug 27, 2021

Conversation

sbimochan
Copy link
Contributor

Changes

  • checks docker run status. Before it used to execute all make build commands even if docker was not running.
  • Early error shown to the user
  • Terminal text color changed
    • made this sentence "Before running this script, please make sure Docker is running and you have made changes to .env file." color RED because it can throw errors
    • "Changing the postgres username & password from .env is highly recommended." to Green since it's a suggestion

install.sh Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yogeshojha yogeshojha merged commit e984335 into yogeshojha:master Aug 27, 2021
@yogeshojha
Copy link
Owner

Hi @sbimochan

Thank you for your contributions.

This has been merged. I look forward to many more contributions from you.

Thanks for making reNgine awesome!

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants