Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gau install #998

Merged
merged 2 commits into from Oct 24, 2023
Merged

Gau install #998

merged 2 commits into from Oct 24, 2023

Conversation

psyray
Copy link
Collaborator

@psyray psyray commented Oct 18, 2023

Fix #997

Add gau in renGine
image

Gauplus is always there but not in the default config.

Need a make down && make up

Fully tested & working

Copy link

@shipko shipko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psyray
Copy link
Collaborator Author

psyray commented Oct 20, 2023

https://github.com/yogeshojha/rengine/pull/998/files#diff-58e45409f99345d0feb8b51f3aa5e664b508a7425305f1f1e720bf372f32f435L70

Please, also remove this line

It's intended, I don't want to do this for backwards compatibility.
If users set gauplus in their scanEngine config, reco will fails.

Maybe remove this in a later release, and implement a DEPRECATED Warning message in the doc

@yogeshojha yogeshojha merged commit 6e5ee8e into yogeshojha:master Oct 24, 2023
3 of 5 checks passed
@psyray psyray deleted the gau-install-v2 branch October 24, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Replace Gauplus by Gau
4 participants