-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate a QR code to export all account details as JSON #735
Conversation
The export button can be at the bottom with the back and delete buttons, also we can open the QR code on another screen where we can give the option to download the QR code |
Sure, that sounds good. I will make the changes accordingly. |
@yogeshpaliyal I have changed the feature like you suggested. Please have a look :) Export button on bottom nav bar: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for approving my PR! However, I notice the PR check CI pipeline has failed and the changes were not merged due to the use of deprecated gradle features. I haven't changed any build scripts though. How can we fix this? |
@divyampahujaa checks failed due to spotless |
@yogeshpaliyal I ran those commands. The issue was with using wildcard imports. I have changed the imports to address this. |
Cool thanks |
Pr Merged thanks @divyampahujaa for the contribution ❤️, will look for other contribution. |
…JSON (#735) * Generate QR code to export account details as JSON * create a popup window screen for displaying qr code * QR code save to gallery feature * Move export via QR code button to the bottom bar * Fix PR checks failing --------- Co-authored-by: Divyam Pahuja <u7467739@anu.edu.au>
…JSON (yogeshpaliyal#735) * Generate QR code to export account details as JSON * create a popup window screen for displaying qr code * QR code save to gallery feature * Move export via QR code button to the bottom bar * Fix PR checks failing --------- Co-authored-by: Divyam Pahuja <u7467739@anu.edu.au>
This pull request addresses issue #559.
Export button:
QR code:
JSON output: