Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a QR code to export all account details as JSON #735

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

divyampahujaa
Copy link
Contributor

This pull request addresses issue #559.

Export button:
image

QR code:
image

JSON output:
image

@yogeshpaliyal
Copy link
Owner

The export button can be at the bottom with the back and delete buttons, also we can open the QR code on another screen where we can give the option to download the QR code

@divyampahujaa
Copy link
Contributor Author

Sure, that sounds good. I will make the changes accordingly.

@divyampahujaa
Copy link
Contributor Author

@yogeshpaliyal I have changed the feature like you suggested. Please have a look :)

Export button on bottom nav bar:
image

Generated QR code in a popup screen:
image

Ability to save the QR code to gallery:
image

yogeshpaliyal
yogeshpaliyal previously approved these changes Oct 18, 2023
Copy link
Owner

@yogeshpaliyal yogeshpaliyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@divyampahujaa
Copy link
Contributor Author

Thank you for approving my PR! However, I notice the PR check CI pipeline has failed and the changes were not merged due to the use of deprecated gradle features. I haven't changed any build scripts though. How can we fix this?

@yogeshpaliyal
Copy link
Owner

@divyampahujaa checks failed due to spotless
Please run these command
./gradlew spotlessApply
./gradle spotlessKotlinApply

@divyampahujaa
Copy link
Contributor Author

@yogeshpaliyal I ran those commands. The issue was with using wildcard imports. I have changed the imports to address this.

@yogeshpaliyal
Copy link
Owner

Cool thanks

@yogeshpaliyal yogeshpaliyal merged commit 5ea20b7 into yogeshpaliyal:master Oct 18, 2023
1 check passed
@yogeshpaliyal
Copy link
Owner

Pr Merged thanks @divyampahujaa for the contribution ❤️, will look for other contribution.

github-actions bot pushed a commit that referenced this pull request Oct 18, 2023
…JSON (#735)

* Generate QR code to export account details as JSON

* create a popup window screen for displaying qr code

* QR code save to gallery feature

* Move export via QR code button to the bottom bar

* Fix PR checks failing

---------

Co-authored-by: Divyam Pahuja <u7467739@anu.edu.au>
github-actions bot pushed a commit to t-regbs/KeyPass that referenced this pull request Oct 20, 2023
…JSON (yogeshpaliyal#735)

* Generate QR code to export account details as JSON

* create a popup window screen for displaying qr code

* QR code save to gallery feature

* Move export via QR code button to the bottom bar

* Fix PR checks failing

---------

Co-authored-by: Divyam Pahuja <u7467739@anu.edu.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants