Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

38 new maint rooms from bee and submissions #10322

Merged
merged 10 commits into from Nov 8, 2020

Conversation

smorgli
Copy link
Contributor

@smorgli smorgli commented Nov 4, 2020

Intent of your Pull Request

Around 28 from bee, rest is submissions by @alao3alao3 and SergeyMeyer
I went through them to check for bullshit, gaming, and errors, should be mostly fine now.
Won't be giving pictures because of how many there are, just check mapdiffs if they generate or discover them ingame.

Why is this good for the game?

More variation is good.

Changelog

馃啈 VeebleFetzer , SergeyMeyer
rscadd: 38 more maint rooms
/:cl:

@smorgli smorgli requested a review from a team as a code owner November 4, 2020 17:44
@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Mapping Will result in a change to a map. labels Nov 4, 2020
@Moja10
Copy link
Contributor

Moja10 commented Nov 4, 2020

5x4_nanitechamber.dmm , 10x5_radiationtherapy.dmm , 10x10_advbotany.dmm all seem a bit too much IMO. Adv botany is basically everything botany has, radiation therapy is roundstart uranium with enough for serious research and printing, and nanite chamber is the entirety of the nanite department. All the others I love though, good PR

@smorgli
Copy link
Contributor Author

smorgli commented Nov 4, 2020

5x4_nanitechamber.dmm , 10x5_radiationtherapy.dmm , 10x10_advbotany.dmm all seem a bit too much IMO. Adv botany is basically everything botany has, radiation therapy is roundstart uranium with enough for serious research and printing, and nanite chamber is the entirety of the nanite department. All the others I love though, good PR

chrome_Gt0qVh1Rna
chrome_UQTp3Tz8as

As for nanite here's a list of what's in there:
chrome_0WcB4LcHiK
3 disks, scanner, program hub, programmer board, nonpublic chamber with its console. That's not enough to do anything. Plus it appears randomly, good for antag play imo.

Comment on lines +524 to +527
/datum/map_template/ruin/station/maint/threexthree/naughtyroom
id= "naughtyroom"
suffix = "3x3_naughtyroom.dmm"
name = "Maint naughtyroom"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/datum/map_template/ruin/station/maint/threexthree/naughtyroom
id= "naughtyroom"
suffix = "3x3_naughtyroom.dmm"
name = "Maint naughtyroom"

@@ -121,19 +121,25 @@ GLOBAL_LIST_EMPTY(chosen_station_templates)
/obj/effect/landmark/stationroom/maint/threexthree
template_names = list("Maint 2storage", "Maint 9storage", "Maint airstation", "Maint biohazard", "Maint boxbedroom", "Maint boxchemcloset", "Maint boxclutter2", "Maint boxclutter3", "Maint boxclutter4", "Maint boxclutter5", "Maint boxclutter6", "Maint boxclutter8",
"Maint boxwindow", "Maint bubblegumaltar", "Maint deltajanniecloset", "Maint deltaorgantrade", "Maint donutcapgun", "Maint dronehole", "Maint gibs", "Maint hazmat", "Maint hobohut", "Maint hullbreach", "Maint kilolustymaid", "Maint kilomechcharger", "Maint kilotheatre",
"Maint medicloset", "Maint memorial", "Maint metaclutter2", "Maint metaclutter4", "Maint metagamergear", "Maint owloffice", "Maint plasma", "Maint pubbyartism", "Maint pubbyclutter1", "Maint pubbyclutter2", "Maint pubbyclutter3", "Maint radspill", "Maint shrine", "Maint singularity", "Maint tanning", "Maint tranquility", "Maint wash")
"Maint medicloset", "Maint memorial", "Maint metaclutter2", "Maint metaclutter4", "Maint metagamergear", "Maint owloffice", "Maint plasma", "Maint pubbyartism", "Maint pubbyclutter1", "Maint pubbyclutter2", "Maint pubbyclutter3", "Maint radspill", "Maint shrine", "Maint singularity",
"Maint tanning", "Maint tranquility", "Maint wash", "Maint command", "Maint dummy", "Maint spaceart", "Maint containmentcell", "Maint naughtyroom")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Maint tanning", "Maint tranquility", "Maint wash", "Maint command", "Maint dummy", "Maint spaceart", "Maint containmentcell", "Maint naughtyroom")
"Maint tanning", "Maint tranquility", "Maint wash", "Maint command", "Maint dummy", "Maint spaceart", "Maint containmentcell")

Also why are these not alphabetical?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would they be, I just add them as i go

@UselessTheremin
Copy link
Contributor

i love the box factory with bart's lucky red hat in it, good reference. one of the best simpsons episodes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This adds new content to the game Mapping Will result in a change to a map.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants