Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Much bigger holodeck, enables actual chess games now. #10353

Merged
merged 15 commits into from Nov 8, 2020
Merged

Much bigger holodeck, enables actual chess games now. #10353

merged 15 commits into from Nov 8, 2020

Conversation

JamieD1
Copy link
Contributor

@JamieD1 JamieD1 commented Nov 7, 2020

Adds 10x9 Holodeck

Chess and shit

image

Changelog

🆑
rscadd: 10x9 Holodeck
/:cl:

@JamieD1 JamieD1 requested a review from a team as a code owner November 7, 2020 23:34
@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Mapping Will result in a change to a map. labels Nov 7, 2020
@athena413
Copy link
Contributor

POG

athena413
athena413 suggested changes Nov 7, 2020
View reviewed changes
Copy link
Contributor

@athena413 athena413 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
image

Perma on IceBox, Eclipse, and Box are still 5x10

@Tipy1802
Copy link

Tipy1802 commented Nov 7, 2020

Finally! Would be great if the pieces were different for the two sides. Maybe white being NT themed and black Antagonist based

@alao3alao3
Copy link
Contributor

don’t we have to change the other holodeck environments to accommodate for the 10x9 holodeck or no

@athena413
Copy link
Contributor

image
the carpet here makes it kinda look like ass

@athena413
Copy link
Contributor

don’t we have to change the other holodeck environments to accommodate for the 10x9 holodeck or no

theyre already changed

@MrHorizons
Copy link
Contributor

I still think it should be a full 10x10.

@smorgli
Copy link
Contributor

smorgli commented Nov 8, 2020

All the existing maps are there, i ported them from tg with adjustements
vivaldi_qVi7oGMW5Q
, this is how i fit the holodeck in box perma:
vivaldi_qyaSH6thDf

smorgli
smorgli approved these changes Nov 8, 2020
View reviewed changes
Copy link
Contributor

@smorgli smorgli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maps reviewed

@JamieD1 JamieD1 merged commit bc327f8 into master Nov 8, 2020
@JamieD1 JamieD1 deleted the 8x8-Holodeck branch November 8, 2020 16:56
Yogbot-13 added a commit that referenced this pull request Nov 8, 2020
@Yogbot-13
Automatic changelog generation #10353 [ci skip]
dc493c3
This was referenced Nov 8, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athena413 athena413 athena413 requested changes

@smorgli smorgli smorgli approved these changes

Assignees
No one assigned
Labels
Feature This adds new content to the game Mapping Will result in a change to a map.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@JamieD1 @athena413 @Tipy1802 @alao3alao3 @MrHorizons @smorgli @Yogbot-13