Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atmospherics to Turbine Shortcut #10395

Merged
merged 11 commits into from Nov 14, 2020

Conversation

FatalEYES
Copy link
Contributor

@FatalEYES FatalEYES commented Nov 12, 2020

Intent of your Pull Request

From what I understand, atmos techs either make their own little space bridge from atmos to the turbine when they're doing fusion, this should just save them the trouble.

Why is this good for the game?

It literally just saves most atmos techs tedious time doing their own basic mapping changes. More time to have fun with fusion experiments.

Changelog

馃啈
rscadd: Added new atmos space bridge/room. Added a holopad to the turbine room as well.
tweak: tweaked the atmos airlock to be more aesthetically pleasing with the new bridge/room. (Thicc airlock boiiii) Also made the gravgen airlock bolted by default because it should be imo.
/:cl:

@FatalEYES FatalEYES requested a review from a team as a code owner November 12, 2020 17:45
@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Mapping Will result in a change to a map. Tweak This PR contains changes to the game. labels Nov 12, 2020
@Hopekz
Copy link
Contributor

Hopekz commented Nov 12, 2020

The idea of a shortcut is alright but using double external doors is a bit weird.
This is the only place this is a thing for external airlocks on the station so it would create inconsistency.

Here is what I'm referring to for people that want screenshots since you didn't post any:
image

@PrinceKirze
Copy link
Contributor

ehhhhhhhhhhhhhh
looks strange.
the double airlock im not crazy about.
the glass connects weirdly to the turbine room.
the glass is strange in general.
idk im not a mapper and while i like the idea of a connection this one is done really weirdly.

@FatalEYES
Copy link
Contributor Author

I do agree with the window into the turbine and that is actually something I missed. The double airlock though is that way so techs are able to drag cannisters into the station from space since now it's actually two tiles wide, but feedback is definitely welcome.

@MrHorizons
Copy link
Contributor

I've tried making a shortcut from atmospherics to the incinerator as here, but I've found that a big problem is that it cuts off external access to the right side of tanks. I've personally never really seen them used, but I don't think it'd be very good to block it off.

The most I've found you can make a shortcut to the incinerator is to have a second atmospherics maintenance door roughly above where it is.

@MrHorizons
Copy link
Contributor

I do agree with the window into the turbine and that is actually something I missed. The double airlock though is that way so techs are able to drag cannisters into the station from space since now it's actually two tiles wide, but feedback is definitely welcome.

Also, I think the planned standard is to two-long airlocks.

@MrHorizons
Copy link
Contributor

As for feedback on the map itself...
image
No. Just no. Yeet that window and replace it with a wall.

For the floors, keep the colors consistent and make it just a plasteel turf rather than a dark plasteel turf.

@FatalEYES
Copy link
Contributor Author

Yeah the window was absolutely an oversight I forgot to change is all, I'll be doing in a bit.

@smorgli
Copy link
Contributor

smorgli commented Nov 12, 2020

馃
chrome_GceMQvEBF2

@FatalEYES
Copy link
Contributor Author

The idea of a shortcut is alright but using double external doors is a bit weird.
This is the only place this is a thing for external airlocks on the station so it would create inconsistency.

Okay, I did alter the external airlock a bit, since it did odd at a second glance.

looks strange.
the double airlock im not crazy about.
the glass connects weirdly to the turbine room.
the glass is strange in general.

Made some changes, hopefully that handled a few of your concerns.

I've tried making a shortcut from atmospherics to the incinerator as here, but I've found that a big problem is that it cuts off external access to the right side of tanks. I've personally never really seen them used, but I don't think it'd be very good to block it off.

Yeah, I was trying to figure out what to do with that for a good while. Then I realized that they can just remove the window and work with the shutter and throw down a holobarrier.

@FatalEYES
Copy link
Contributor Author

FatalEYES commented Nov 13, 2020

Screenshot_3
For those who want to see it here.

@FatalEYES
Copy link
Contributor Author

For the floors, keep the colors consistent and make it just a plasteel turf rather than a dark plasteel turf.

I personally like the darker floors for what's essentially just a sort of storage room, like toxins storage. But I do see where you're coming from.

@TheLinuxOS
Copy link

I dont like this for a few of the reasons mentioned above, firstly the double door external airlock, and also the fact that it blocks access to the right side gas area. It is much easier in my opinion for an atmos tech to just remove the window and place a holofan if they want to quickly go between the two.

@Jarod1200
Copy link

This looks good to me. Aside from the double door airlock being a bit odd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This adds new content to the game Mapping Will result in a change to a map. Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants