Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gives Incinerator Maintenance Door Proper Permissions #10531

Merged
merged 4 commits into from Nov 30, 2020
Merged

Gives Incinerator Maintenance Door Proper Permissions #10531

merged 4 commits into from Nov 30, 2020

Conversation

alao3alao3
Copy link
Contributor

apng
what the fuck

Changelog

馃啈
rscadd: Added Atmos permissions to incinerator maint door
rscdel: Maintenance Permission from incinerator maint door
/:cl:

@alao3alao3 alao3alao3 requested a review from a team as a code owner November 28, 2020 03:00
@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Mapping Will result in a change to a map. Revert / Deletion Altoids is probably mad about this labels Nov 28, 2020
@PrinceKirze
Copy link
Contributor

am i mistaken or was it always on maint perms

@alao3alao3
Copy link
Contributor Author

alao3alao3 commented Nov 28, 2020 •
edited

it was, some guy said it ought not to be now that we got that bridge
why people could just wander into there in the first place is beyond me

@Jarod1200
Copy link

Hmm the incinerator is technically a tertiary power source for the station if solars and the main engine are unavailable. Perhaps it would be better to make it general engineering access instead of just atmos access.

@alao3alao3
Copy link
Contributor Author

engi and atmos it is

@Jarod1200
Copy link

I like this because it makes paramedics think twice before wandering into chernobyl and bringing it to medbay

smorgli
smorgli suggested changes Nov 28, 2020
View reviewed changes
Copy link
Contributor

@smorgli smorgli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You made it openable only by people with atmos AND engi acess.
You want to use the req_one_access_txt var to make that an OR

@JamieD1 JamieD1 requested a review from smorgli November 29, 2020 11:37
smorgli
smorgli suggested changes Nov 29, 2020
View reviewed changes
_maps/map_files/YogStation/YogStation.dmm Outdated
},
/obj/machinery/door/airlock/maintenance{
name = "Incinerator Access";
req_access_txt = "0";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rogue var, we don't want this because it does literally nothing and bloats the map code.
In fastdmm2, just delete the entire var and confirm it to make it go default. (greyed out not white)

smorgli
smorgli approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@smorgli smorgli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

descriptive commits

@smorgli smorgli merged commit 8e5054e into yogstation13:master Nov 30, 2020
Yogbot-13 added a commit that referenced this pull request Nov 30, 2020
@Yogbot-13
Automatic changelog generation #10531 [ci skip]
cfb83a0
@ColonyBot ColonyBot mentioned this pull request Nov 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smorgli smorgli smorgli approved these changes

Assignees
No one assigned
Labels
Feature This adds new content to the game Mapping Will result in a change to a map. Revert / Deletion Altoids is probably mad about this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alao3alao3 @PrinceKirze @Jarod1200 @smorgli @Yogbot-13