Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Gallery to the Library and Places the Sec Service Outpost at Escape #11339

Merged
merged 9 commits into from Apr 13, 2021
Merged

Adds a Gallery to the Library and Places the Sec Service Outpost at Escape #11339

merged 9 commits into from Apr 13, 2021

Conversation

alao3alao3
Copy link
Contributor

General Documentation

Intent of your Pull Request

Adds a painting gallery to the library and places the sec service outpost at escape.
cpng
Note that an entire side of the library was destroyed and rebuilt, as opposed to just removing the sec outpost and placing the gallery in, and is the reason some things like lights, pipes or otherwise vary. The secure art enclosure (the blue table area I stole from TG's meta) is only accessible by the curator.

bpng
The air alarm has been placed in that bottleneck hall leading to the podbay dock area. The airlock that used to be where the Sec Service outpost is has been shoved down a bit, but does not extend past the escape airlock arms so it shouldn't cause any issues with any of the shuttles.

Why is this change good for the game?

Gallery is cool and allows for the critique of art against each other, as opposed to the mindless and random paintings dotted about that only look nice and serve as decor, though they're still around.
This was done at the request of Lyis so if you want reasoning behind it ping council ping Lyis, a person who is apart of council.

Wiki Documentation

Image of Library and Escape has to be changed

Changelog

🆑
rscadd: Added a gallery in the Library and the Security Service Outpost to Escape
rscdel: Removed the old Security Service Outpost
/:cl:

Council and HM wanted this in. I think its getting in.

@alao3alao3 alao3alao3 requested a review from a team as a code owner April 12, 2021 01:44
@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Mapping Will result in a change to a map. Revert / Deletion Altoids is probably mad about this labels Apr 12, 2021
@Marmio64
Copy link
Contributor

rip service sec post, you're now just the escape checkpoint...

@alao3alao3
Copy link
Contributor Author

if you’ve got a spot to put the damn service post go ahead and suggest it

Copy link
Contributor

@smorgli smorgli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hate map conflicts

Copy link
Contributor

@smorgli smorgli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, i spotted some issues like :
vivaldi_t0bRZwV9IA
vivaldi_Sm531Pze2f
vivaldi_oIgMm9cvov
Also added sidings to the carpet/wood border so it looks nicer and moved an air alarm that was on the same wall as a fire extinguisher.
Was thinking about adding a desk for the sec checkpoint but idk.
Will merge tommorrowish to leave time for this to get more feedback

@smorgli smorgli added the Map - Approved This PR's mapping side has been approved by a mapping maintainer label Apr 12, 2021
@Marmio64
Copy link
Contributor

if you’ve got a spot to put the damn service post go ahead and suggest it

remove clerk since he is just a useless validhunter and replace it with the service sec post boom, no need to thank me

@smorgli smorgli merged commit 2016e2c into yogstation13:master Apr 13, 2021
Yogbot-13 added a commit that referenced this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This adds new content to the game Map - Approved This PR's mapping side has been approved by a mapping maintainer Mapping Will result in a change to a map. Revert / Deletion Altoids is probably mad about this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants