Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces gibbing on being heretic sacrificed with being sent to brazil #12548

Merged

Conversation

SomeguyManperson
Copy link
Contributor

@SomeguyManperson SomeguyManperson commented Oct 27, 2021

Document the changes in your pull request

fun and intuitive gameplay feature
getting sacrificed by a heretic will revive you and send you to a void instead of gibbing you, causing several negative effects over the course of a few minutes then teleporting you back to the station to somewhere probably safe

Wiki Documentation

probably undocumented

Changelog

🆑
tweak: heretic sacrifices no longer gib people
rscadd: new brazil area for holding heretic sacrifices (this is temporary) (but not good for your health)
/:cl:

@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Mapping Will result in a change to a map. labels Oct 27, 2021
@maxion12345
Copy link
Contributor

kinda feels hugbox ngl
you are being sacrificed to an eldrich abomination for internet points you should explode

@Cartlord
Copy link
Contributor

This seems like a horrible idea

@SomeguyManperson
Copy link
Contributor Author

kinda feels hugbox ngl you are being sacrificed to an eldrich abomination for internet points you should explode

you don't read many scary stories do you

@Xoxeyos
Copy link
Contributor

Xoxeyos commented Oct 28, 2021

Show me an interesting, and challenging environment, with some traps, and monsters thrown in, and I might be a bit more interested. I wouldn't want this to be an easy thing to come back from, and I'd want it to be an even more difficult thing to recover from.

code/game/turfs/closed.dm Outdated Show resolved Hide resolved
Copy link
Contributor

@smorgli smorgli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Map appears fine.

@Marmio64
Copy link
Contributor

Should make it like the scp 106 pocket dimension

@smorgli smorgli changed the title Replaces gibbing on being heretic sacrificed with being sent to brazil Replaces gibbing on being heretic sacrificed with being sent to brazil Oct 28, 2021
@smorgli
Copy link
Contributor

smorgli commented Oct 28, 2021

Sorry you had an extra space there, i couldn't stand it

@Hopekz
Copy link
Contributor

Hopekz commented Oct 28, 2021

IMO this PR has the potential to make this part much "cooler" instead of something simple like getting gibbed.
It might even introduce more fun into the round for the people sent, depending on how this void/"brazil" looks.

No idea why people have strong opinions for or against this yet since there isn't really much here to judge and the PR might look completely different once it is ready to be judged.

Also for @SomeguyManperson : Your changelog sucks so hopefully you make that better sometime

@Xoxeyos
Copy link
Contributor

Xoxeyos commented Oct 29, 2021

I know this is a draft, but putting a negative over a space, and leaving a 40x40~ area is unsatisfying, to say the least.
This is just a white space.
I'd like to have to solve a puzzle of some sort, face difficult enemies, or have some other such obstacle.

@maxion12345
Copy link
Contributor

A puzzle, or some choice would be infinitely better then just being sent somewhere for a bit then coming back. Makes getting captured have no real consequences for the one being captured, you just waste a bit of time. People are probably just going to ask people to sacrifice them (and people will do it) instead of going after them normally. We know there were people that would let vampires just suck their blood if they asked. Is that self-antaging? I don't know, kinda? But it still happens regardless.

@smorgli
Copy link
Contributor

smorgli commented Oct 29, 2021

The japanese restaurant is full of content, yet people get bored to death there anyway.

@SomeguyManperson
Copy link
Contributor Author

The japanese restaurant is full of content, yet people get bored to death there anyway.

that's maybe because the ninja jail is somewhere you get put for the rest of the round and not for a couple minutes

@SomeguyManperson
Copy link
Contributor Author

For reference, the current fun and intuitive heretic post-sacrifice gameplay looks something like this

image

you get gibbed and the majority of your stuff is deleted if it wasn't stripped first
the riveting gameplay afterwards is pressing the do not resuscitate button and waiting for a midround antag

@Xoxeyos
Copy link
Contributor

Xoxeyos commented Oct 31, 2021

I've already spoken quite a bit about my thoughts for this PR in the public dev channel, and I don't wish to repeat everything here because someone lacks the context for what I am saying, but I believe this can fleshed out much more; As I believe, putting someone in a blank space with a cheapo respawn timer on it's own isn't exactly inspiring.

https://discord.com/channels/134720091576205312/205784753352343552/903496910537629756

@SomeguyManperson SomeguyManperson marked this pull request as ready for review November 8, 2021 19:44
@SomeguyManperson SomeguyManperson requested a review from a team as a code owner November 8, 2021 19:44
@SomeguyManperson SomeguyManperson merged commit eb1e118 into yogstation13:master Nov 8, 2021
@Yogbot-13 Yogbot-13 added the Tweak This PR contains changes to the game. label Nov 8, 2021
Yogbot-13 added a commit that referenced this pull request Nov 8, 2021
@Cartlord
Copy link
Contributor

Cartlord commented Nov 8, 2021

What the fuck were you thinking?
You closed your PR because of backlash, repoened it, and then merged it under 24 hours later. This stinks of cowardice, like you closed it to HIDE it from people until it was "ready" for a merge.

@maxion12345
Copy link
Contributor

maxion12345 commented Nov 8, 2021

selfmerge go brrrr
also damn he is turning into oranges isn't he. We even got a photo of him preforming a lip to lip docking maneuver with a lizard

@Marmio64
Copy link
Contributor

Marmio64 commented Nov 8, 2021

Kinda sus

@Hopekz
Copy link
Contributor

Hopekz commented Nov 8, 2021

Everyone is overreacting for no reason, this isn't "hidden" because everyone involved gets an email notification and it even gets posted to like 4 different places.

This change isn't significant enough to get mad over I'm pretty sure if it actually was a hidden commit that literally no-one would notice except a few weeks from now where someone would describe this as a "cool" thing that happens when you get sacrificed vs just getting killed.

Cartlord added a commit to Cartlord/Yogstation that referenced this pull request Nov 10, 2021
@SomeguyManperson SomeguyManperson deleted the jeosnerfsheretic branch November 21, 2021 14:28
@bruhlookatthisdood
Copy link
Contributor

created a glitch where cult could summon someone who had been sent to brazil
resuliting in an invincible killing machine hailing nar'sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This adds new content to the game Mapping Will result in a change to a map. Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants