-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bounty] Ports prisoner from TG #13893
Conversation
tgstation/tgstation#49235 would probably be a good idea so they're not bored out of their minds. |
I am bad at mapping and have no experience at it. If i would try to port it, permabrig will end up being without energy, normal access and air
Ill check them |
Actually i can probably try to port tgstation/tgstation#49235, but maybe as another PR |
we have different plasmaman suit sprites from tg |
i'd be better if you did it closer to ours |
@@ -690,7 +690,7 @@ | |||
name = "Monkey" | |||
antag_flag = ROLE_MONKEY | |||
antag_datum = /datum/antagonist/monkey/leader | |||
restricted_roles = list("Cyborg", "AI") | |||
restricted_roles = list("Prisoner","Cyborg", "AI") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make a protected roles list for these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually i dont think it is required, since monkey gamemode is removed. I put prisoner restriction here just because... yes.
Co-authored-by: tattax <71668564+tattax@users.noreply.github.com>
I didn't do the sprites, and i am a bad spriter. |
Co-authored-by: tattax <71668564+tattax@users.noreply.github.com>
It's a bounty, you're supposed to do all of it to claim the prize |
Would have to be separate (probably outside of the bounty) |
Actually moderators aproved this bounty like "15 dollars for porting prisoner from TG", so event just porting only tgstation/tgstation#48819 would be fine. And the map change i am still planning to port, but not now. |
When merged |
Merge conflicts, hooray |
Not dead. |
christ :( conflicts.. |
When i will FINALLY get a computer i will fix it, but for now i can't do anything about this |
Fix time |
Document the changes in your pull request
Ports prisoner job from TG, and four pull requests related to it:
tgstation/tgstation#48819
tgstation/tgstation#49229
tgstation/tgstation#49177
tgstation/tgstation#49423
tgstation/tgstation#49861
I did change every map for this role except GaxStation, because it is currently under development and i don't want merge conflicts(fuck merge conflicts).
Wiki Documentation
A wikipage about it?
Changelog
🆑 Author: RaveRadbury
rscadd: Adds Prisoner role
imageadd: Adds icons for prisoner plasmeme envirosuit
rscadd: The biogenerator can now produce soy milk.
/:cl: