Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Box] Adjusts Janitor Closet, Part of Atmos, And Janitorial/Atmos Maint #14834

Merged
merged 3 commits into from Jul 14, 2022

Conversation

VaelophisNyx
Copy link
Contributor

@VaelophisNyx VaelophisNyx commented Jul 13, 2022

Document the changes in your pull request

Before:
ss (2022-07-13 at 01 48 21)

After
ss (2022-07-13 at 01 47 52)

Adjusts the janitorial closet to account for there being, shocker, more than one janitor!
Adds a second janicart, and space cleaner bottle
swaps the water tank for a high capacity water tank
shifts the disposal and table/rack combo down a tile
moves atmos' disposal down a tile and deletes the two pipe dispensers because...RPDs exist and atmos is swimming in them? If you need a pipe dispenser you can just...go build one.
adjusts the firelocks in the engineering hallway entrance because they were spaced out 1 tile for seemingly no reason
adds white trim to the janitorial closet
adds a modular PC vendor to engineering because why not

Changelog

馃啈
rscadd: adds trims to the janitorial closet
rscadd: Adds a second janicart, and space cleaner bottle to the janitor closet
rscadd: adds a modular PC vendor to the engineering foyer
rscdel: deletes the two pipe dispensers in atmos
tweak: changes the water tank in the janitorial closet into a high capacity variant
tweak: moves engineering hallway northern firelocks
tweak: shifts janitorial/atmos maint hallway so nothing is too far from where it was, to make room for the janitorial closet changes
tweak: moves atmos' disposal down a tile
tweak: shifts the janitor closet disposal and table/rack combo down a tile
/:cl:

also technically atmos
also also maints
@VaelophisNyx VaelophisNyx requested a review from a team as a code owner July 13, 2022 07:33
@Yogbot-13 Yogbot-13 added the Mapping Will result in a change to a map. label Jul 13, 2022
Copy link
Contributor

@ToasterBiome ToasterBiome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fit the water vapor canister back in

@ToasterBiome ToasterBiome added the Awaiting - Action - Author This PR is awaiting an action from the author label Jul 13, 2022
bad decision but ok, I'll do it
@redmoogle
Copy link
Contributor

The modular PC vendor in atmos is kinda weird. Why not place that in engineering instead?

@VaelophisNyx
Copy link
Contributor Author

specifically because I wasn't touching engineering with this PR

Copy link
Contributor

@ToasterBiome ToasterBiome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move vendor, you can touch engi with this

@VaelophisNyx
Copy link
Contributor Author

Ok, I'll get that done

scoots the charger and mesons down one table to squeeze it into that alcove
@VaelophisNyx
Copy link
Contributor Author

It is done

@ToasterBiome ToasterBiome merged commit f357bb5 into yogstation13:master Jul 14, 2022
@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Revert / Deletion Altoids is probably mad about this Tweak This PR contains changes to the game. labels Jul 14, 2022
Yogbot-13 added a commit that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting - Action - Author This PR is awaiting an action from the author Feature This adds new content to the game Mapping Will result in a change to a map. Revert / Deletion Altoids is probably mad about this Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants