New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flips Boxstation Cloning and Genetics #17262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smorgli
suggested changes
Jan 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- double wire
- All the doors except the one leading to rnd corridor have a lot of different accesses that will only cause confusion when someone wants to give access to this area, keep just the proper ones for the proper door. So cloning for cloning and genetics for genetics: https://github.com/yogstation13/Yogstation/blob/master/code/__DEFINES/access.dm
- as an addition, maybe add an rd c_tag for the genetics camera?
- considering maybe removing this thindow, it looks weird next to a wall:
Aside from these I think this is fine
|
@wejengin2 馃悙 |
smorgli
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
The hallway inclusion that leads to xenobio did one extra thing: it made genetics a fortress, lacking maint access.
Every other map has maint access to genetics/cloning, but box was lacking now.
Flips them so genetics is in a better position to be accessed from maintenance (and more susceptible to sabotage)
Also buffs cloning by making it closer to treatment and having it's "EMP cloner in maint" be the little area above it instead.
Wiki Documentation
Genetics lab and cloning on BoxStation are flipped.
Changelog
馃啈
mapping: Flips genetics and cloning on BoxStation
/:cl: