Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flips Boxstation Cloning and Genetics #17262

Merged
merged 4 commits into from Jan 6, 2023

Conversation

ToasterBiome
Copy link
Contributor

Document the changes in your pull request

image

image

The hallway inclusion that leads to xenobio did one extra thing: it made genetics a fortress, lacking maint access.

Every other map has maint access to genetics/cloning, but box was lacking now.

Flips them so genetics is in a better position to be accessed from maintenance (and more susceptible to sabotage)
Also buffs cloning by making it closer to treatment and having it's "EMP cloner in maint" be the little area above it instead.

Wiki Documentation

Genetics lab and cloning on BoxStation are flipped.

Changelog

馃啈
mapping: Flips genetics and cloning on BoxStation
/:cl:

@ToasterBiome ToasterBiome requested a review from a team as a code owner January 2, 2023 02:47
@Yogbot-13 Yogbot-13 added the Mapping Will result in a change to a map. label Jan 2, 2023
Copy link
Contributor

@smorgli smorgli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. double wire
    image
  2. All the doors except the one leading to rnd corridor have a lot of different accesses that will only cause confusion when someone wants to give access to this area, keep just the proper ones for the proper door. So cloning for cloning and genetics for genetics: https://github.com/yogstation13/Yogstation/blob/master/code/__DEFINES/access.dm
  3. as an addition, maybe add an rd c_tag for the genetics camera?
  4. considering maybe removing this thindow, it looks weird next to a wall:
    image

Aside from these I think this is fine

@ToasterBiome
Copy link
Contributor Author

  1. double wire
  2. All the doors except the one leading to rnd corridor have a lot of different accesses that will only cause confusion when someone wants to give access to this area, keep just the proper ones for the proper door. So cloning for cloning and genetics for genetics: https://github.com/yogstation13/Yogstation/blob/master/code/__DEFINES/access.dm
  3. as an addition, maybe add an rd c_tag for the genetics camera?
  4. considering maybe removing this thindow, it looks weird next to a wall:

Aside from these I think this is fine

  1. Fixed
  2. These match the same doors as were on there previously. Most importantly, the 3 different accesses on the door between them is for the weird situation where someone has access to gene but not cloning. Working as intended
  3. Genetics camera already has a c_tag, unless you mean adding it the RD network, then I will do that.

image
Flipped this so that the glass can be outside.

@Hopekz
Copy link
Contributor

Hopekz commented Jan 5, 2023

@wejengin2 馃悙

Copy link
Contributor

@smorgli smorgli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess

@ToasterBiome ToasterBiome merged commit 8b3700f into master Jan 6, 2023
@ToasterBiome ToasterBiome deleted the fdmm-patch-18102017-ToasterBiome branch January 6, 2023 02:40
Yogbot-13 added a commit that referenced this pull request Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping Will result in a change to a map.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants