Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nerfs Cargo - No more Factorio Simulator Free money exploit 2023 #17414

Merged
merged 3 commits into from Jan 11, 2023

Conversation

JamieD1
Copy link
Contributor

@JamieD1 JamieD1 commented Jan 8, 2023

Too many people are abusing the autolathes to get free money, this causes lags and is just not a viable solution.

馃啈
tweak: Autolathed Items can no longer be sold for profit.
/:cl:

@JamieD1 JamieD1 requested a review from a team as a code owner January 8, 2023 22:53
@Yogbot-13 Yogbot-13 added the Tweak This PR contains changes to the game. label Jan 8, 2023
@JamieD1 JamieD1 changed the title Nerfs Cargo - No more Factory Simulator Free money exploit 2023 Nerfs Cargo - No more Factorio Simulator Free money exploit 2023 Jan 8, 2023
@Moltijoe
Copy link
Contributor

Moltijoe commented Jan 8, 2023

rip factorio

code/game/machinery/autolathe.dm Outdated Show resolved Hide resolved
@ReddicusDragon
Copy link
Contributor

new_items.autolathed var doesn't exist :(

@JamieD1
Copy link
Contributor Author

JamieD1 commented Jan 8, 2023

oopsie

@ReddicusDragon
Copy link
Contributor

if this fails again I'm slapping on the closing after 24h tag

@JamieD1
Copy link
Contributor Author

JamieD1 commented Jan 8, 2023

if this fails again I'm slapping on the closing after 24h tag

Dont do it

Copy link
Contributor

@adamsong adamsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works fine, solution feels like a shortcut, but eh

@@ -143,6 +143,8 @@ GLOBAL_DATUM_INIT(welding_sparks, /mutable_appearance, mutable_appearance('icons
/// Is this item fryable without a syndicate frying pan
var/fryable = FALSE

var/printed = FALSE
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just add a trait for that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just add a trait for that?

You mean an ITEM/OBJ Flag?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one that is added through ADD_TRAIT

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, probably best that not every item has an additional variable to track

@JamieD1
Copy link
Contributor Author

JamieD1 commented Jan 9, 2023

Code works fine, solution feels like a shortcut, but eh

It is, honestly was the easiest solution I could think of

@Moja10
Copy link
Contributor

Moja10 commented Jan 9, 2023

Exporting autolathe items has been a thing for forever, its literally the most poverty way to make money. People wouldn't have to do it if literally every single other method wasn't nerfed to dirt. Mining exports, gas exports, bounties, and export prices have all been repeatedly slashed to the point where spamming 2000 fire extinguishers is now the most profitable thing. Do you see how the problem isn't the fire extinguishers, but the several combined changes that lead us down this accursed path? This was literally never a problem until the nerfs get so bad that spamming garbage is more profitable than any of the actual efforted exports are.

Copy link
Contributor

@BurgerLUA BurgerLUA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a flag but other than that it's gucci

@JamieD1
Copy link
Contributor Author

JamieD1 commented Jan 10, 2023

Exporting autolathe items has been a thing for forever, its literally the most poverty way to make money. People wouldn't have to do it if literally every single other method wasn't nerfed to dirt. Mining exports, gas exports, bounties, and export prices have all been repeatedly slashed to the point where spamming 2000 fire extinguishers is now the most profitable thing. Do you see how the problem isn't the fire extinguishers, but the several combined changes that lead us down this accursed path? This was literally never a problem until the nerfs get so bad that spamming garbage is more profitable than any of the actual efforted exports are.

Its a problem because I made the autolathe automatic.

Lags the server, makes garbage subsystem eat shit.

@JamieD1 JamieD1 merged commit ad37bce into master Jan 11, 2023
@JamieD1 JamieD1 deleted the Autolathe branch January 11, 2023 00:22
Yogbot-13 added a commit that referenced this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants