Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluespace locker no longer has infinite power #17517

Merged
merged 2 commits into from Jan 22, 2023

Conversation

ThatLing
Copy link
Contributor

@ThatLing ThatLing commented Jan 16, 2023

Document the changes in your pull request

It's stupid that the bluespace locker gives you an area with infinite power for free. You will now have to provide an external power source (e.g. P.A.C.M.A.N generator) if you want to use machines inside.

I added an APC inside the locker and removed the requires_power = FALSE flag so stuff actually requires power. The APC spawns with 90% charge like default, however the 2 lights inside will use some of it over time.

image

Changelog

🆑
tweak: Bluespace locker no longer has infinite power, it's powered by an APC now and requires an external power source.
/:cl:

@ThatLing ThatLing added Tweak This PR contains changes to the game. i ded labels Jan 16, 2023
@ThatLing ThatLing requested a review from a team as a code owner January 16, 2023 11:28
@Yogbot-13 Yogbot-13 added the Mapping Will result in a change to a map. label Jan 16, 2023
Copy link
Contributor

@smorgli smorgli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use the autoname apc's, please use one of the manual ones to set the area and name by hand.

@smorgli
Copy link
Contributor

smorgli commented Jan 16, 2023

My personal opinion is that this is needlesly limiting, bluespace locker is supposed to be this magical fun place where you can make crazy projects without having to worry about things such as no power for your machines.

@MajManatee
Copy link
Contributor

I agree with Wej

@ReddicusDragon ReddicusDragon added the Awaiting - Action - Author This PR is awaiting an action from the author label Jan 16, 2023
@ReddicusDragon
Copy link
Contributor

this is stupid. Why ruin player fun? People love using the bluespace locker as a place to bullshit and build funny small projects

@TheRyeGuyWhoWillNowDie
Copy link
Contributor

Mid

@RG4ORDR
Copy link
Contributor

RG4ORDR commented Jan 17, 2023

Absolutely not.
I wont even give an explanation. Just bad all round.

@ThatLing ThatLing requested a review from smorgli January 17, 2023 10:13
@ThatLing
Copy link
Contributor Author

My personal opinion is that this is needlesly limiting, bluespace locker is supposed to be this magical fun place where you can make crazy projects without having to worry about things such as no power for your machines.

Why should BS locker be "magical" and have infinite power? If you want to build crazy projects without worrying about power, we have both aux base construction and normal construction area on Yogstation, with the former even giving you your own solar for power.

this is stupid. Why ruin player fun? People love using the bluespace locker as a place to bullshit and build funny small projects

God forbid people have to actually put in a little effort to get power inside the locker. You're acting like this will make the locker useless when in reality there's a dozen ways to power it, such as a PACMAN or simply changing out the power cell.

@ThatLing ThatLing removed the Awaiting - Action - Author This PR is awaiting an action from the author label Jan 17, 2023
@Moltijoe
Copy link
Contributor

Moltijoe commented Jan 18, 2023

Would be nice if the APC inside the locker could charge from the APC of the room the locker is in. That way its not infinite power, but doesnt gimp making cool non power creating setups inside the locker.

@TheLinuxOS
Copy link

This is a horrible change, not only does it detract from the magic of the bluespace locker- It also removes 1 of the precious tiles by making you build a generator in there that could go completely against the aesthetic.

@adamsong
Copy link
Contributor

If you are going to make it draw power, make it draw from the area in which the outside is

@ThatLing
Copy link
Contributor Author

This is a horrible change, not only does it detract from the magic of the bluespace locker- It also removes 1 of the precious tiles by making you build a generator in there that could go completely against the aesthetic.

Or you can just replace the power cell in the APC and still use all of the tiles, crazy right? I hope you realize that the bluespacer having infinite power because "magic" is an insanely lame excuse.

Copy link
Contributor

@smorgli smorgli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

map fine

@TheLinuxOS
Copy link

This is a horrible change, not only does it detract from the magic of the bluespace locker- It also removes 1 of the precious tiles by making you build a generator in there that could go completely against the aesthetic.

Or you can just replace the power cell in the APC and still use all of the tiles, crazy right? I hope you realize that the bluespacer having infinite power because "magic" is an insanely lame excuse.

and I hope you realize how insanely lame it is to try to limit the bluespace locker

@smorgli smorgli added the Controversial People are divided on this PR label Jan 18, 2023
@ThatLing
Copy link
Contributor Author

This is a horrible change, not only does it detract from the magic of the bluespace locker- It also removes 1 of the precious tiles by making you build a generator in there that could go completely against the aesthetic.

Or you can just replace the power cell in the APC and still use all of the tiles, crazy right? I hope you realize that the bluespacer having infinite power because "magic" is an insanely lame excuse.

and I hope you realize how insanely lame it is to try to limit the bluespace locker

What a cope reply

@Moltijoe
Copy link
Contributor

why are people trying to balance around the bluespace locker? it's tedious as hell to find it, if someone finds it only to figure out all the fun gimmicks were killed, that's kinda cringe.

@JamieD1 JamieD1 removed the i ded label Jan 19, 2023
@JamieD1
Copy link
Contributor

JamieD1 commented Jan 19, 2023

why are people trying to balance around the bluespace locker? it's tedious as hell to find it, if someone finds it only to figure out all the fun gimmicks were killed, that's kinda cringe.

Its hardly tedious to find, people go assistant just to find the locker and they find it before like 20-30 mins. If anything it needs to be made harder to find.

@ThatLing
Copy link
Contributor Author

why are people trying to balance around the bluespace locker? it's tedious as hell to find it, if someone finds it only to figure out all the fun gimmicks were killed, that's kinda cringe.

You're legitimately delusional if you think this "kills" all fun gimmicks you can do

@UltraBigRat
Copy link

Biggest question here, why? whats the reasoning here other then bluespess locker bad i nerf? i really dont see how this is good for the game whatsoever.

@JamieD1 JamieD1 merged commit deb685e into yogstation13:master Jan 22, 2023
Yogbot-13 added a commit that referenced this pull request Jan 22, 2023
@ThatLing ThatLing deleted the bluespacecock branch January 22, 2023 13:28
@CrazyDrakkon
Copy link

The APC power/status stays the same when the locker is destroyed.

Cartlord added a commit to Cartlord/Yogstation that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Controversial People are divided on this PR Mapping Will result in a change to a map. Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet