Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gives miners 1 jaunter at round start (in locker) #17686

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Gives miners 1 jaunter at round start (in locker) #17686

merged 1 commit into from
Jan 30, 2023

Conversation

Aquizit
Copy link
Contributor

@Aquizit Aquizit commented Jan 28, 2023

Document the changes in your pull request

Should I have made this 2 weeks ago? Yes. But I was dumb and forgot I knew how to do locker things.

I feel like this is the compromise between people who want to keep their chasm and people who don't want to punish people for not knowing where chasms may appear (if new) or if you lag into one. To note I am in the second camp.

One free get out of jail card. If you lose the first one and don't get a second and fall in another chasm, well that's on you, buddy.

If people like this -- can revert #17340 and close #17685

Changelog

馃啈
tweak: Miners get a jaunter in their locker
experimental: If people like this chasms can come back
/:cl:

@Yogbot-13 Yogbot-13 added the Tweak This PR contains changes to the game. label Jan 28, 2023
@Aquizit
Copy link
Contributor Author

Aquizit commented Jan 28, 2023

I am perfectly willing to have this closed if the judgment is "nope shoulda said something when the first PR was open."

@smorgli
Copy link
Contributor

smorgli commented Jan 28, 2023

This is better

Copy link
Contributor

@MajManatee MajManatee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we ALL shoulda thought bout this before. Bring back chasams

@MajManatee MajManatee merged commit 70c7cc4 into yogstation13:master Jan 30, 2023
Yogbot-13 added a commit that referenced this pull request Jan 30, 2023
@smorgli
Copy link
Contributor

smorgli commented Jan 31, 2023

@Aquizit i guess you can try a revert now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants