Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds spawnpoints for space ninja on IceMeta for when it rolls #22096

Merged
merged 2 commits into from
May 31, 2024

Conversation

cowbot92
Copy link
Contributor

@cowbot92 cowbot92 commented May 23, 2024

Document the changes in your pull request

I don't see why this event shouldn't be allowed to roll on this station.

Why is this good for the game?

Not technically a bugfix but I like space ninjas

Testing

image

Changelog

馃啈

mapping: Adjusts it so that space ninjas can spawn on icemeta properly

/:cl:

@cowbot92 cowbot92 requested a review from a team as a code owner May 23, 2024 22:35
@github-actions github-actions bot added the Mapping Will result in a change to a map. label May 23, 2024
@Moltijoe
Copy link
Contributor

I think this might make carp spawn on icemeta too
Instead add a backup, so if ninja fails to pick a location, instead have it spawn based on other criteria

@cowbot92
Copy link
Contributor Author

I think this might make carp spawn on icemeta too Instead add a backup, so if ninja fails to pick a location, instead have it spawn based on other criteria

this is smart

@cowbot92
Copy link
Contributor Author

I think this might make carp spawn on icemeta too Instead add a backup, so if ninja fails to pick a location, instead have it spawn based on other criteria

I added a double check without needing the map part

@cowbot92 cowbot92 removed the Mapping Will result in a change to a map. label May 24, 2024
@cowbot92 cowbot92 removed the request for review from a team May 24, 2024 01:12
@RG4ORDR
Copy link
Contributor

RG4ORDR commented May 24, 2024

I think this might make carp spawn on icemeta too Instead add a backup, so if ninja fails to pick a location, instead have it spawn based on other criteria

Is there a way to flavor text Spacecarp to Icecarp???

@cowbot92
Copy link
Contributor Author

I think this might make carp spawn on icemeta too Instead add a backup, so if ninja fails to pick a location, instead have it spawn based on other criteria

Is there a way to flavor text Spacecarp to Icecarp???

yes and you can do it!

@Moltijoe Moltijoe merged commit 9682b33 into yogstation13:master May 31, 2024
14 checks passed
Yogbot-13 added a commit that referenced this pull request May 31, 2024
@cowbot92 cowbot92 deleted the SpaceNinjaIceMeta branch June 5, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants