Fixes boris preventing law display on round end #7358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkar598
reviewed
Dec 23, 2019
code/__HELPERS/roundend.dm
Outdated
| @@ -359,7 +359,10 @@ | |||
| if(aiPlayer.mind) | |||
| parts += "<b>[aiPlayer.name]</b> (Played by: <b>[aiPlayer.mind.key]</b>)'s laws [aiPlayer.stat != DEAD ? "at the end of the round" : "when it was <span class='redtext'>deactivated</span>"] were:" | |||
| parts += aiPlayer.laws.get_law_list(include_zeroth=TRUE) | |||
|
|
|||
| else if(aiPlayer.deployed_shell) | |||
There was a problem hiding this comment.
Suggested change
| else if(aiPlayer.deployed_shell) | |
| else if(aiPlayer?.deployed_shell?.mind) |
Just a tiny improvement, makes it take less code, else if leading into an if is yucky
There was a problem hiding this comment.
aiPlayer will always be reference to object unless the global AI list got fucked up
yogstation13-bot
added a commit
that referenced
this pull request
Dec 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes couple of UI problems with AI
馃啈
bugfix: boris module no longer prevents laws displayn on round end
bugfix: borgs no longer have the PDA verbs
tweak: AI alert UI made look better
/:cl: