Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ Monstermos - Putting the 99% LAG FREE in 99% LAG FREE #7981

Merged
merged 6 commits into from Apr 24, 2020

Conversation

monster860
Copy link
Member

@monster860 monster860 commented Mar 15, 2020

C++ CODE: https://github.com/yogstation13/extools/tree/monstermos

Monstermos now runs in c++ land!

Things that are in c++ land:

  • Gas mixtures now live in c++ land, with the /datum/gas_mixture being a shell around it
  • The turf grid now also exists in c++ land
  • Atmos processing happens in c++ land
  • Turf gas overlay calculations

Things that aren't in c++ land yet, but I should put in c++ land:

  • Gas reactions

@monster860 monster860 added DO NOT MERGE Should not be merged without express approval from a Head Dev Needs review This PR needs to be reviewed Performance This has some affect on server performance. SPEEEEEED WORK IN PROGRESS This PR will take a while before its complete, but is actively being worked on. TESTMERGE IMPORTANT Important stuff. Literally the best PR My god its beautiful labels Mar 15, 2020
@alexkar598
Copy link
Member

alexkar598 commented Mar 15, 2020

Monstermos but now its proprietary so noone else can remove it

@ThatLing
Copy link
Contributor

Waiting for the benchmark results

@MCHSL
Copy link
Contributor

MCHSL commented Mar 15, 2020

gas mixture transfer
                      Ops/sec
before             -    26,824
remove inner_moles -    33,058
transfer_to proc   -    52,910
extools            - 2,015,134

@alexkar598
Copy link
Member

needs to work with travis, we cant affort to lose travis especially with the current maintainer situation

@monster860
Copy link
Member Author

Don't worry, I'll throw up a linux build before merging the PR

@ghost
Copy link

ghost commented Mar 19, 2020

This thing has a really high chance of crashing the server. So uh.... yeah that's fun. Prepare for that

doesn't that kind of ruin the entire point lol

@Firewolf34
Copy link
Contributor

Firewolf34 commented Mar 21, 2020

Though technically, space is cold, oftentimes space feels warm, after a time. Because in a vacuum, there's no convection - you're relying on mostly radiative heat transfer. So unless you touch something, or have some form of radiator system attached to you, when in space you'll actually overheat most of the time even with normal exertion, because your body has no practical way to remove heat from itself.

This was a real problem for the first spacewalks when space-suits didn't really have any cooling. On Voskhod 2, one of the first spacewalks, Cosmonaut Leonov reportedly had about half his suit filled with sweat by the end of the relatively short EVA. Remember, you can't evaporate sweat in a spacesuit.

So the point is technically Monster you've got it right from the crew's perspective. You probably won't feel cold in space. You'll probably sweat your balls off, unless you're exposed directly to vacuum, in which case your sweat will helpfully instantly vaporize off your skin.

(By the way, fucking excellent PR here. This is amazing.)

fuck

Fixes the server hemorrhaging memory due to extools not decrementing ref counts

Increases defauilt tank pressure

make space cold or some shit

floor tile rips

Fixes code assuming that the heat capacity is nonzero

:facepalm:

Fixes crash

fixes some bugs

fuck *facepalm*

the fastening

removes Del() in favor of an internal c++ hook

Fixes vent-pump math
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Should not be merged without express approval from a Head Dev Fetish Content Oh hell no IMPORTANT Important stuff. Literally the best PR My god its beautiful Needs review This PR needs to be reviewed Performance This has some affect on server performance. SPEEEEEED WORK IN PROGRESS This PR will take a while before its complete, but is actively being worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants