Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

better captain annoncement #8275

Merged
merged 2 commits into from
Apr 28, 2020

Conversation

enkidienne
Copy link
Contributor

makes the captain annoncement able to have multiple lines and spaces. Like a centcom annoncement

changelog:
/馃啈
tweak: changed the stripped format of the Captain's announcement to a full format that allows more creativity and possibilities.
/:cl:

makes the captain annoncement able to have multiple lines and spaces. Like a centcom annoncement
Copy link
Member

@alexkar598 alexkar598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao, this removes all sanitzation for it, meaning anyone will be able to post any HTML content they want

@Hopekz
Copy link
Contributor

Hopekz commented Apr 25, 2020

I think the main reason for this is that captain announcement is random user input (whoever plays captain) while Centcom announcement is via admins+ so if we do something like an HTML attack it will be less likely since it is closely monitored as far as who gets access to it.

@enkidienne
Copy link
Contributor Author

i fixed it, assigned it to a multi line strip

@alexkar598 alexkar598 merged commit 8641834 into yogstation13:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants