Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gives the Lavaland base monstermos firelocks and stronger windows. #8285

Merged
merged 3 commits into from
Apr 29, 2020

Conversation

smorgli
Copy link
Contributor

@smorgli smorgli commented Apr 26, 2020

Intent of your Pull Request

Marked most of the changes with a highlight, hopefully i didn't forget anything.

P3AMxTxloO

lWHIUCXVHq

The stronger windows are there to prevent wind tunnels from being created, imo this is a necessary step towards adapting to monstermos.
I suppose the firelocks part is obvious, placed them at all airlocks and in some corridors.
The RCD is not there.
Hopefully with these changes the mining base will become less of a deathtrap when depressurized.

Changelog

🆑
rscadd: added monstermos firelocks to the mining base
tweak: most windows on the base are now reinforced
/:cl:

@smorgli smorgli requested a review from Ktlwjec1 as a code owner April 26, 2020 20:17
@yogstation13-bot yogstation13-bot added Feature This adds new content to the game Mapping Will result in a change to a map. Tweak This PR contains changes to the game. labels Apr 26, 2020
@Hopekz
Copy link
Contributor

Hopekz commented Apr 26, 2020

Why does the mining base need an RCD?
They get materials and a furnace to smelt on-site

The RCD will just become a part of their mining kit that they take to break into ruins

@smorgli
Copy link
Contributor Author

smorgli commented Apr 26, 2020

You may be right, they get materials and tools anyway. Giving them an RCD would just let them run over lava more easily, probably wont be used for actually fixing the station.

@smorgli
Copy link
Contributor Author

smorgli commented Apr 26, 2020

Removed the RCD crate

@smorgli smorgli changed the title Gives the Lavaland base an RCD, monstermos firelocks, and stronger windows. Gives the Lavaland base monstermos firelocks and stronger windows. Apr 26, 2020
Copy link
Contributor

@Hopekz Hopekz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from me. KTL (the head mapper) will decide your fate

@Ktlwjec1
Copy link
Contributor

The firelocks don't actually close automatically with monstermos on lavaland, which is why they were never added. Windows are fine though, I don't mind them at all. I'll merge the firelocks anyway since they can be manually closed/opened so they'll still be useful.

@Ktlwjec1 Ktlwjec1 merged commit 422ddbf into yogstation13:master Apr 29, 2020
@smorgli smorgli deleted the lavalandatmos branch June 14, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This adds new content to the game Mapping Will result in a change to a map. Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants