Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security added to round end report #8389

Merged
merged 9 commits into from May 6, 2020
Merged

Security added to round end report #8389

merged 9 commits into from May 6, 2020

Conversation

MenacingManatee
Copy link
Contributor

Intent of your Pull Request

All members of security are added to end round report under traitors, with IC name, byond name, and whether they survived or died
Tested with the warden, HoS, detective, and security officer, both alive and dead.

TLDR: Just adds a small cool thing to encourage/reward playing security

Changelog

🆑
rscadd: Security added to round end report
/:cl:

@yogstation13-bot yogstation13-bot added the Feature This adds new content to the game label May 5, 2020
@MenacingManatee
Copy link
Contributor Author

MenacingManatee commented May 5, 2020

Some screenshots:

Images

Living warden
Warden_live

Dead detective, with a traitor
det_dead_plus_tator

Lawyer (aka no security)
no_sec

@ThatLing
Copy link
Contributor

ThatLing commented May 5, 2020

Regarding the last image you posted, it should only be displayed if there are security officers

Also, what's with the stupid border?

@MenacingManatee
Copy link
Contributor Author

I made it match the border everything else had.
Good point on the only display if there's sec, I'll fix that

@MenacingManatee
Copy link
Contributor Author

Fixed

@MegaEmpirical
Copy link

I like it. Does it emphasize commendations given to them as well might encourage heads to use them.

Also, does it state their department?

@MenacingManatee
Copy link
Contributor Author

I like it. Does it emphasize commendations given to them as well might encourage heads to use them.

Also, does it state their department?

Commendations are stated separately and were in the end round report before this PR. I'm not sure how to get their department, but I'll play around with it a bit. If I figure it out I'll add it

Tested multiple times to make sure everything still works as intended
@Xantam-13
Copy link
Member

I like this

@JamieD1
Copy link
Contributor

JamieD1 commented May 5, 2020

Can we make it match the formatting of traitors ie the spacing is wack,

Or make traitors match this one.

           Just want it lined up.

@MegaEmpirical
Copy link

Sounds good.

I know commendations are already in, I just thought this would be a cool place to emphasize them.

@MenacingManatee
Copy link
Contributor Author

MenacingManatee commented May 6, 2020

Can we make it match the formatting of traitors ie the spacing is wack,

Or make traitors match this one.

           Just want it lined up.

Fixed

Image Fixed alignment ![fixed_alignment](https://user-images.githubusercontent.com/26894750/81134810-8b2b9680-8f1b-11ea-95bb-f70d94aed6fd.png)

@alexkar598 alexkar598 added the Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer label May 6, 2020
@Hopekz Hopekz merged commit 87c0aee into yogstation13:master May 6, 2020
@Hopekz Hopekz removed the Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer label May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This adds new content to the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants