-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security added to round end report #8389
Conversation
Updating to current repo
Regarding the last image you posted, it should only be displayed if there are security officers Also, what's with the stupid border? |
I made it match the border everything else had. |
Fixed |
I like it. Does it emphasize commendations given to them as well might encourage heads to use them. Also, does it state their department? |
Commendations are stated separately and were in the end round report before this PR. I'm not sure how to get their department, but I'll play around with it a bit. If I figure it out I'll add it |
Tested multiple times to make sure everything still works as intended
I like this |
Can we make it match the formatting of traitors ie the spacing is wack, Or make traitors match this one.
|
Sounds good. I know commendations are already in, I just thought this would be a cool place to emphasize them. |
Fixed ImageFixed alignment ![fixed_alignment](https://user-images.githubusercontent.com/26894750/81134810-8b2b9680-8f1b-11ea-95bb-f70d94aed6fd.png) |
Intent of your Pull Request
All members of security are added to end round report under traitors, with IC name, byond name, and whether they survived or died
Tested with the warden, HoS, detective, and security officer, both alive and dead.
TLDR: Just adds a small cool thing to encourage/reward playing security
Changelog
🆑
rscadd: Security added to round end report
/:cl: