Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports Dynamic Gamemode Code from Beestation. #8390

Merged
merged 83 commits into from Jun 14, 2020
Merged

Ports Dynamic Gamemode Code from Beestation. #8390

merged 83 commits into from Jun 14, 2020

Conversation

Xoxeyos
Copy link
Contributor

@Xoxeyos Xoxeyos commented May 5, 2020

Ports over the Dynamic Gamemode Code from Beestation, I have tested it, all seems to be well. Some gamemodes are missing from Dynamic, such as gangs, but I could add that in later. Also a readme for documentation. The readme is in 'code\game\gamemodes\dynamic' .

🆑 Xoxeyos
rscadd: Ports over general dynamic code from Beestation. Thank you qwertyquerty, ShiftyRail, and Toxici11i for making this possible.
/🆑

@Xoxeyos
Copy link
Contributor Author

Xoxeyos commented May 5, 2020

Take a look here for some of what it does. tgstation/tgstation#44639

Also here for some images. https://imgur.com/a/KLqOdAY

Here is the Beestation PR, minor edits were needed to be made. https://github.com/BeeStation/BeeStation-Hornet/pull/399/files\

Here's /TG/s explaination on it. https://tgstation13.org/wiki/Game_Mode#Dynamic

Here's /VG/s explanation on the math behind it. However it may have very minor changes from our own.
vgstation-coders/vgstation13#22410

@github-actions github-actions bot added the Admin This PR affects administrators label May 5, 2020
code/game/gamemodes/dynamic/dynamic_rulesets_roundstart.dm, line 390, column 2:
error: possible unreachable code here
@ThatLing
Copy link
Contributor

ThatLing commented May 5, 2020

Some gamemodes are missing from Dynamic, such as gangs, but I could add that in later.

Why not add it now?

@Hopekz
Copy link
Contributor

Hopekz commented May 5, 2020

Why is this better?

@Xoxeyos
Copy link
Contributor Author

Xoxeyos commented May 5, 2020

Why is this better?

Please put more of an explanation into what you're asking.

@Xoxeyos
Copy link
Contributor Author

Xoxeyos commented May 5, 2020

Some gamemodes are missing from Dynamic, such as gangs, but I could add that in later.

Why not add it now?

I want to make sure this is well received, and has a test merge, before I add anything else in, to ensure I don't break anything.

@Hopekz
Copy link
Contributor

Hopekz commented May 5, 2020

Please put more of an explanation into what you're asking.

What does this provide over what we already have in terms of the experience?
"Why should this be merged?" a.k.a "Why is this better?"

@AdamElTablawy
Copy link
Contributor

It should be merged because it's Dynamic Hopekz you sack of fuckwits

And the pr's from fucking TG, not bee

@Xoxeyos
Copy link
Contributor Author

Xoxeyos commented May 5, 2020

Please put more of an explanation into what you're asking.

What does this provide over what we already have in terms of the experience?
"Why should this be merged?" a.k.a "Why is this better?"

Well, I believe that this will be a fun and interesting gamemode, as it is easily configurable, using the administration game panel, and it will allow the community to give ideas on the subject, and hopefully give the community a good experience. It's also possible to add or remove antagonists, and side antagonists from the rolling list.

@Xoxeyos
Copy link
Contributor Author

Xoxeyos commented May 5, 2020

It should be merged because it's Dynamic Hopekz you sack of fuckwits

And the pr's from fucking TG, not bee

I used bee's code, as /TG/'s code has been heavily modified because of the direction of their codebase, bee is now more similar to our codebase. If I had used /TG/ code, I would have to edit several more files, as, for example, their mob.dm file has different variable names, unlike ours.

@Hopekz
Copy link
Contributor

Hopekz commented May 5, 2020

It should be merged because it's Dynamic Hopekz you sack of fuckwits

Compelling.

And the pr's from fucking TG, not bee

Better than your usual shitposts I'm awarding you a golden star
download

@alexkar598 alexkar598 added the Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer label May 6, 2020
@Xoxeyos
Copy link
Contributor Author

Xoxeyos commented May 24, 2020

Adding some more stuff to vampire.

@Xoxeyos
Copy link
Contributor Author

Xoxeyos commented May 24, 2020

Adding some more shadowling stuff soon.

@Xoxeyos
Copy link
Contributor Author

Xoxeyos commented May 24, 2020

I'm ready for another test merge, or a merge.

@Xoxeyos Xoxeyos requested a review from fluffe9911 June 3, 2020 18:32
If set to TRUE, dynamic mode will be able to draft this ruleset again later on. (doesn't apply for roundstart rules(?))
@JamieD1 JamieD1 merged commit 0928d8e into yogstation13:master Jun 14, 2020
@Marmio64
Copy link
Contributor

why does it say vampire costs a whole fucking 25 points, but apparently lings and traitors are only 10?

@MegaEmpirical
Copy link

Vampires can reproduce? Could be why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin This PR affects administrators Feature This adds new content to the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet