Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes stat panels a browser (removes lag I guess) #8407

Merged
merged 4 commits into from
May 6, 2020

Conversation

monster860
Copy link
Member

@monster860 monster860 commented May 6, 2020

Stat panels are a horrible thing that BYOND designed that suck and cause a lot of lag on both the client and server.

This PR moves the client-side part to a browser, and the server-side part to a subsystem, where lag can be eliminated.

Not that it will say "MC not initialized..." until the MC initializes. Don't complain about it because that's how it's supposed to be. IF you really need the MC panel during that time you can go to the Debug tab and turn on the legacy MC tab.

馃啈 monster860
tweak: Stat panels now use a browser.
/:cl:

@monster860 monster860 requested a review from AsV9 as a code owner May 6, 2020 07:46
@yogstation13-bot yogstation13-bot added the Tweak This PR contains changes to the game. label May 6, 2020
@github-actions github-actions bot added the Admin This PR affects administrators label May 6, 2020
@ynot01
Copy link
Contributor

ynot01 commented May 6, 2020

what does it look like?

@monster860 monster860 added TESTMERGE Performance This has some affect on server performance. SPEEEEEED labels May 6, 2020
@monster860
Copy link
Member Author

image

@monster860 monster860 merged commit 02ce376 into yogstation13:master May 6, 2020
@JamieD1
Copy link
Contributor

JamieD1 commented May 6, 2020

Literally the best PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin This PR affects administrators Performance This has some affect on server performance. SPEEEEEED Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants